Skip to content

feat(test-benchmark): support repricing marker for stateful benchmark#2430

Merged
LouisTsai-Csie merged 1 commit into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:stateful-repricing-marker
Mar 26, 2026
Merged

feat(test-benchmark): support repricing marker for stateful benchmark#2430
LouisTsai-Csie merged 1 commit into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:stateful-repricing-marker

Conversation

@LouisTsai-Csie

@LouisTsai-Csie LouisTsai-Csie commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

In the past, we could not provide -m repricing flag to limit the test run. This PR adds repricing marker support to stateful benchmark.

And add repricing marker label for:

  • test_account_access
  • test_sstore_erc20_mint
  • test_sload_erc20_balanceof
  • test_storage_sload_same_key_benchmark
  • test_ext_account_query_warm

Also, move test_ext_account_query_warm under stateful folder.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie changed the title Stateful repricing marker feat(test-benchmark): support repricing marker for stateful benchmark Mar 6, 2026
@codecov

codecov Bot commented Mar 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.35%. Comparing base (21407ec) to head (d63df12).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2430   +/-   ##
================================================
  Coverage            86.35%   86.35%           
================================================
  Files                  599      599           
  Lines                36904    36904           
  Branches              3771     3771           
================================================
  Hits                 31868    31868           
  Misses                4485     4485           
  Partials               551      551           
Flag Coverage Δ
unittests 86.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisTsai-Csie
LouisTsai-Csie force-pushed the stateful-repricing-marker branch from ad3b7fa to 7c2ecbb Compare March 6, 2026 12:44
@LouisTsai-Csie
LouisTsai-Csie marked this pull request as ready for review March 6, 2026 12:44
@LouisTsai-Csie
LouisTsai-Csie force-pushed the stateful-repricing-marker branch 3 times, most recently from b9a9f68 to 55f4ca8 Compare March 10, 2026 07:25
@LouisTsai-Csie
LouisTsai-Csie force-pushed the stateful-repricing-marker branch 2 times, most recently from 4cc96d1 to 99f9792 Compare March 17, 2026 15:38
@LouisTsai-Csie
LouisTsai-Csie force-pushed the stateful-repricing-marker branch from 99f9792 to d63df12 Compare March 25, 2026 07:22

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Users need to run "-m stateful and repricing", checking thats the intended way to run based on the current conftest :)

Comment thread tests/benchmark/stateful/bloatnet/test_account_query.py
@LouisTsai-Csie

Copy link
Copy Markdown
Contributor Author

@spencer-tb i think we only need to specify the test path with -m repricing marker? Since PR #2496 merged and i've rebased on top of it, the command should be simplified now.

@LouisTsai-Csie
LouisTsai-Csie merged commit def3a0c into ethereum:forks/amsterdam Mar 26, 2026
18 checks passed
@danceratopz danceratopz added A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-feat Category: an improvement or new feature labels Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants