Skip to content

Update: improve report location for no-mixed-operators - #12328

Merged
platinumazure merged 1 commit into
eslint:masterfrom
chiawendt:no-mixed-operators-report-location
Oct 21, 2019
Merged

Update: improve report location for no-mixed-operators#12328
platinumazure merged 1 commit into
eslint:masterfrom
chiawendt:no-mixed-operators-report-location

Conversation

@chiawendt

@chiawendt chiawendt commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule

What changes did you make? (Give an overview)
Make no-mixed-operators report both start and end location, instead of only start location.

let p = a && b || c
//        ~    ~    before
//        ~~   ~~   after

Is there anything you'd like reviewers to focus on?
No

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Sep 27, 2019
@g-plane g-plane added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 28, 2019
kaicataldo
kaicataldo approved these changes Sep 28, 2019
View reviewed changes

@kaicataldo kaicataldo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic mentioned this pull request Oct 17, 2019
Merged
@mdjermanovic mdjermanovic self-assigned this Oct 20, 2019
@mdjermanovic

mdjermanovic commented Oct 20, 2019

Copy link
Copy Markdown
Member

LGTM, thanks!

One more 👍 to accept.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 21, 2019
@platinumazure

platinumazure commented Oct 21, 2019

Copy link
Copy Markdown
Member

This is now accepted!

@platinumazure
platinumazure merged commit 349ed67 into eslint:master Oct 21, 2019
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@chiawendt
chiawendt deleted the no-mixed-operators-report-location branch March 1, 2020 15:52
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
Open
This was referenced Apr 3, 2020
Merged
Merged
@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Apr 20, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes
+2 more reviewers
@platinumazure platinumazure platinumazure approved these changes
@kaicataldo kaicataldo kaicataldo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mdjermanovic mdjermanovic

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chiawendt @mdjermanovic @platinumazure @kaicataldo @g-plane