Do not send empty If-None-Match in tarball request - #2738
Merged
Conversation
Absent entity tag list was not allowed before RFC 9110 published this June. However, it would be better not to send it. Cowlib, for example, treats it invalid, and Cowboy rejects such a request :)
ferd
approved these changes
Aug 22, 2022
ferd
left a comment
ferd
left a comment
Collaborator
There was a problem hiding this comment.
Seems good. I've forgotten a lot about how that code works, but the clearer handling around empty binaries can't hurt much and Dialyzer agrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absent entity tag list was not allowed before RFC 9110 published this June. However, it would be better not to send it. Cowlib, for example, treats it invalid, and Cowboy rejects such a request :)
I'm also not really sure if it's needed to conditionally request tarballs (
GET /tarballs/PACKAGE-VERSION.tar). Seems like locally cached tarball can be used as long as its checksum is considered valid. Mix/Hex, for example, uses conditional requests only to fetch new package registry (GET /packages/PACKAGE).