Use binder directory for configuration files#85
Merged
ericmjl merged 4 commits intoericmjl:masterfrom Feb 15, 2020
Merged
Conversation
This is now unnecessary, so don't do it. Also remove the instructions that aren't needed now.
Contributor
Author
|
For reference, the Binder build for this branch on my fork is here: https://mybinder.org/v2/gh/matthewfeickert/bayesian-stats-modelling-tutorial/use-binder-dir-example |
Owner
|
Wonderful stuff, @matthewfeickert! |
Owner
|
I appreciate all the thought you put into the PR, @matthewfeickert. This is how open source is supposed to be done! 😄 |
Contributor
Author
|
Ah, thank you @ericmjl! That's so kind of you to say. 🙂 The work that you do for the Python community (like this true gem of a tutorial repo) is truly inspirational and I'm more then pleased if I can have helped out in a very small way. |
Collaborator
|
Echoing sentiments in both directions here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to @ericmjl's tweet RE: Binder configuration file conflicts, this PR adopts the use of a
binderdirectory for configuration files which eliminates any conflict asAs placing the Conda
environment.ymlconfig file affects the path that both the user focused documentation and the CI use, paths and docs that explicitly use the path to the config file are updated.As this does now require users to think more explicitly about the path to the
environment.ymlat environment creation time I can understand that this might be something that could be a deal breaker for this PR. However, I think that most people should be fine with typing a few more letters and probably don't deeply care where their environment config files live.This also reverts the movement of the
Dockerfileand the.dockerignoreas this was just done to avoid the issue, but there is no reason to do this anymore so don't.Finally, the Binder badge used is updated to reflect the modern (as of 2019) Binder badge (with logo).