Skip to content

(Enyo) InputHeader: it needs to add exception from 'Input' pre-fix - #2958

Open
Sangwook-Lee wants to merge 1 commit into
release-2.6.4-rc.18from
ENYO-4862-sangwook
Open

(Enyo) InputHeader: it needs to add exception from 'Input' pre-fix#2958
Sangwook-Lee wants to merge 1 commit into
release-2.6.4-rc.18from
ENYO-4862-sangwook

Conversation

@Sangwook-Lee

Copy link
Copy Markdown

Issue

InputHeader is cut off because Input height was changed.

Fix

InputHeader shouldn't be applied changed height from Input.
So, I added hegiht: inherit; to Header.less to maintain original height size.

ENYO-4862 (Enyo) InputHeader: it needs to add exception from 'Input' pre-fix
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee sangwook1203.lee@lge.com

InputHeader shouldn't be applied changed height from Input.
So, I added hegiht: inherit; to Header.less to maintain original height size.

ENYO-4862 (Enyo) InputHeader: it needs to add exception from 'Input' pre-fix
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee sangwook1203.lee@lge.com
@Djspaceg

Copy link
Copy Markdown
Contributor

I can't make a reliable estimate of what height: inherit will do on an <input> field within a non-statically sized element. :\ This will need to be tested to verify the consequences. The consequences should be localizable to the single component though. Just make sure that it doesn't alter the height of Header with titleBelow and subTitleBelow present.

@Sangwook-Lee

Sangwook-Lee commented Oct 31, 2017

Copy link
Copy Markdown
Author

@Djspaceg Thanks for review. We can test it in http://10.186.120.63/~sangwook/InputHeaderSample/dist/.
I think it'd be better to apply 'height' in input.less file except for 'input-header class' if that's possible. Is there any better solutions?

@Djspaceg

Djspaceg commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

I'd need more information or testing to provide alternative ideas.

@Sangwook-Lee

Copy link
Copy Markdown
Author

@Djspaceg ,

Or, I think we can set "height" and "line-height" when parent is NOT "headerInput".

Input.less
&:not(.moon-input-header-input-decorator) > .moon-input { line-height: 57px; height: 57px; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants