Skip to content

fix(WMenuItem): setContents() on the current item moves the selection to the previous item #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saddamr3e wants to merge 2 commits into from
Closed

fix(WMenuItem): setContents() on the current item moves the selection to the previous item #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7090e0
fix(WMenu): removeItem() selects wrong item when currently-selected i…
saddamr3e Jun 17, 2026
0e2da3c
fix(WMenuItem): restore selection in setContents() instead of changin…
saddamr3e Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Wt/WMenuItem.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ void WMenuItem::setContents(std::unique_ptr<WWidget> contents,
int menuIdx = -1;
WMenu *menu = menu_;
std::unique_ptr<WMenuItem> self;
bool wasCurrent = false;
if (menu) {
menuIdx = menu->indexOf(this);
wasCurrent = menu->currentItem() == this;
self = menu->removeItem(this);
}

Expand All @@ -133,6 +135,11 @@ void WMenuItem::setContents(std::unique_ptr<WWidget> contents,

if (menu) {
menu->insertItem(menuIdx, std::move(self));
if (wasCurrent) {
// Restore the selection without re-emitting triggered() / itemSelected()
menu->setCurrent(menuIdx);
menu->select(menuIdx, true);
}
}
}

Expand Down
23 changes: 23 additions & 0 deletions test/widgets/WMenuTest.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,26 @@ BOOST_AUTO_TEST_CASE(WMenu_addItem_change_index_for_internal_path_match)
BOOST_TEST(menu->currentIndex() == previousIndex);
}

// Regression test: setContents() on the currently-selected item must not
// change the active selection.
BOOST_AUTO_TEST_CASE(WMenuItem_setContents_keeps_current_selection)
{
Wt::Test::WTestEnvironment testEnv;
Wt::WApplication app(testEnv);

Wt::WStackedWidget *stack = app.root()->addNew<Wt::WStackedWidget>();
Wt::WMenu *menu = app.root()->addNew<Wt::WMenu>(stack);

menu->addItem("Item 0", std::make_unique<Wt::WText>("Content 0"));
Wt::WMenuItem *item1 = menu->addItem("Item 1", std::make_unique<Wt::WText>("Content 1"));
menu->addItem("Item 2", std::make_unique<Wt::WText>("Content 2"));

menu->select(item1);
BOOST_REQUIRE(menu->currentIndex() == 1);

item1->setContents(std::make_unique<Wt::WText>("New content 1"));

BOOST_TEST(menu->currentItem() == item1);
BOOST_TEST(menu->currentIndex() == 1);
}