Skip to content

Add a stub for _Unwind_RaiseException #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Apr 29, 2016
+12 −1
Merged

Add a stub for _Unwind_RaiseException #4104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4052,8 +4052,19 @@ LibraryManager.library = {
return 0; // we cannot succeed
},

_Unwind_RaiseException__deps: ['__cxa_find_matching_catch', '$EXCEPTIONS'],
_Unwind_RaiseException: function(ex) {

@kripken kripken Feb 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this just call cxa_throw?

@tomaka tomaka Feb 17, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, but cxa_throw takes three parameters and I'm not familiar enough with emscripten to know how to extract the relevant values from ex.

@kripken kripken Feb 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you can call cxa_throw(ex, null, null).

abort('Unwind_RaiseException');
// TODO
Module.printErr('Warning: _Unwind_RaiseException is not correctly implemented');
EXCEPTIONS.infos[ex] = {
ptr: ex,
adjusted: ex,
type: null,
destructor: null,
refcount: 0
};
EXCEPTIONS.last = ex;
{{{ makeThrow('ex') }}}
},

_Unwind_DeleteException: function(ex) {
Expand Down