optionally prevent a double AMD compile#144
Closed
kellyselden wants to merge 2 commits into
Closed
Conversation
Contributor
|
wouldn't we want |
Member
Author
|
In ember-cli, yes. I didn't want to make any assumptions about other potential consumers of this lib. |
Member
Author
|
Added a callback so ember-cli can print the same deprecation warning as it did with AmdFunnel. |
Contributor
|
I believe the work that motivated this change has taken a different direction, closing for now. Let me know if I have closed this in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AmdFunnel in ember-cli has optimizations in it to do as little file IO as possible. https://github.com/ember-cli/ember-cli/blob/bd36eca668f8fab21cc9cdfdaae97ffcdc1de9ee/lib/broccoli/ember-app.js#L1652. As it turns out, these optimizations are not good enough, and early exit doesn't seem possible. I decided to try a different approach, to catch the string right before the compile and prevent it going through a second time. The AmdFunnel code can be removed if this is merged.
cc @twokul