Added SDL based audio example.#62
Merged
Merged
Conversation
Earlier SDL crate versions were not able to initialise more than once, but now user can also use SDL to produce audio, not only to create windows and display content. Audio related embedded project may see this as a benefit, to be able to run the audio engines on simulator without much modification.
libesz
force-pushed
the
audio-example
branch
from
February 24, 2025 13:11
4d7cd17 to
07b75e4
Compare
5 tasks
rfuest
requested changes
Feb 25, 2025
rfuest
left a comment
Member
There was a problem hiding this comment.
Looks good, expect for a few nits and some missing comments.
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Contributor
Author
|
Thanks for the review. I think I addressed all comments. |
rfuest
requested changes
Feb 28, 2025
rfuest
left a comment
Member
There was a problem hiding this comment.
A few more suggestions.
Is there a way I can fix the stable build, or can we just ignore it?
Don't worry about that in this PR. At some point this repo needs to be migrated from CircleCI to GitHub Actions, at which point it would be easier to bump the MSRV for this crate to fix the build. But the same error has showed up elsewhere before and might need some further investigation.
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier SDL crate versions were not able to initialise more than once, but now user can also use SDL to produce audio, not only to create windows and display content. Audio related embedded project may see this as a benefit, to be able to run the audio engines on simulator without much modification.
Thank you for helping out with embedded-graphics-simulator development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
[add your PR description here]