Skip to content

Added SDL based audio example.#62

Merged
rfuest merged 13 commits into
embedded-graphics:masterfrom
libesz:audio-example
Mar 1, 2025
Merged

Added SDL based audio example.#62
rfuest merged 13 commits into
embedded-graphics:masterfrom
libesz:audio-example

Conversation

@libesz

@libesz libesz commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Earlier SDL crate versions were not able to initialise more than once, but now user can also use SDL to produce audio, not only to create windows and display content. Audio related embedded project may see this as a benefit, to be able to run the audio engines on simulator without much modification.

Thank you for helping out with embedded-graphics-simulator development! Please:

  • Check that you've added passing tests and documentation
  • Add an example where applicable
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

[add your PR description here]

Earlier SDL crate versions were not able to initialise more than once, but now user can also use SDL to produce audio, not only to create windows and display content. Audio related embedded project may see this as a benefit, to be able to run the audio engines on simulator without much modification.

@rfuest rfuest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, expect for a few nits and some missing comments.

Comment thread examples/audio.rs Outdated
Comment thread CHANGELOG.md Outdated
Comment thread examples/audio.rs
Comment thread examples/audio.rs Outdated
Comment thread examples/audio.rs Outdated
Comment thread examples/audio.rs Outdated
libesz and others added 6 commits February 27, 2025 21:55
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
@libesz

libesz commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I think I addressed all comments.
Is there a way I can fix the stable build, or can we just ignore it?

@rfuest rfuest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions.

Is there a way I can fix the stable build, or can we just ignore it?

Don't worry about that in this PR. At some point this repo needs to be migrated from CircleCI to GitHub Actions, at which point it would be easier to bump the MSRV for this crate to fix the build. But the same error has showed up elsewhere before and might need some further investigation.

Comment thread examples/sdl-audio.rs Outdated
Comment thread examples/sdl-audio.rs Outdated
Comment thread examples/sdl-audio.rs Outdated
Comment thread examples/sdl-audio.rs
libesz and others added 4 commits February 28, 2025 19:43
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Co-authored-by: Ralf Fuest <mail@rfuest.de>

@rfuest rfuest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rfuest
rfuest merged commit 4a7b741 into embedded-graphics:master Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants