MainWindow: center on X11 - #884
Merged
Merged
Conversation
Member
|
Just a thought: I see a lot of these if (wayland) { } else { do_xserver} in multiple repos. |
jeremypw
reviewed
Jul 4, 2025
jeremypw
left a comment
jeremypw
left a comment
Collaborator
There was a problem hiding this comment.
I have test in a virtual machine (uninstalled in test mode) and the only difference between Wayland and X11 I noticed is a small movement of the window when the underlying (VM) window was focused. However, this is not going to happen in a real install and could be an artifact of the VM. It did not happen with Wayland though.
Probably best wait for a review from some-one who can test this safely under more realistic conditions (or give instructions)
Member
Author
Merged
lenemter
reviewed
Jul 26, 2025
Co-authored-by: Leo <lenemter@gmail.com>
lenemter
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #881