Honor de.sorunome.msc2409.push_ephemeral flag in appservice handler - #19928
Merged
anoadragon453 merged 1 commit intoJul 13, 2026
Merged
Conversation
anoadragon453
requested review from
anoadragon453
and removed request for
anoadragon453
July 13, 2026 11:34
anoadragon453
approved these changes
Jul 13, 2026
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Fixes a regression introduced in #19758.
That PR tried to maintain support for the old, unstable flag. But this change without the one in this PR meant that service.supports_ephemeral only applied to the new, stable config option. Thus, deployments on the old config option broke.
Seems we should have some unit tests which runs with an AS still using and expecting the old unstable identifier.
Thanks for catching this @weebl2000, and sorry about the disruption.
anoadragon453
enabled auto-merge (squash)
July 13, 2026 11:38
auto-merge was automatically disabled
July 13, 2026 11:56
Head branch was pushed to by a user without write access
weebl2000
force-pushed
the
fix/appservice-unstable-ephemeral-regression
branch
from
July 13, 2026 11:56
e4a0734 to
ee0b081
Compare
weebl2000
force-pushed
the
fix/appservice-unstable-ephemeral-regression
branch
from
July 13, 2026 11:56
ee0b081 to
8ac9e5a
Compare
Contributor
Author
|
Updated changelog.d filename to reference the PR rather than the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19927
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.