Skip to content

Honor de.sorunome.msc2409.push_ephemeral flag in appservice handler - #19928

Merged
anoadragon453 merged 1 commit into
element-hq:developfrom
weebl2000:fix/appservice-unstable-ephemeral-regression
Jul 13, 2026
Merged

Honor de.sorunome.msc2409.push_ephemeral flag in appservice handler#19928
anoadragon453 merged 1 commit into
element-hq:developfrom
weebl2000:fix/appservice-unstable-ephemeral-regression

Conversation

@weebl2000

Copy link
Copy Markdown
Contributor

fixes #19927

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@weebl2000
weebl2000 requested a review from a team as a code owner July 8, 2026 09:34
@CLAassistant

CLAassistant commented Jul 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@anoadragon453
anoadragon453 requested review from anoadragon453 and removed request for anoadragon453 July 13, 2026 11:34
@anoadragon453 anoadragon453 self-assigned this Jul 13, 2026

@anoadragon453 anoadragon453 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a regression introduced in #19758.

That PR tried to maintain support for the old, unstable flag. But this change without the one in this PR meant that service.supports_ephemeral only applied to the new, stable config option. Thus, deployments on the old config option broke.

Seems we should have some unit tests which runs with an AS still using and expecting the old unstable identifier.

Thanks for catching this @weebl2000, and sorry about the disruption.

@anoadragon453
anoadragon453 enabled auto-merge (squash) July 13, 2026 11:38
auto-merge was automatically disabled July 13, 2026 11:56

Head branch was pushed to by a user without write access

@weebl2000
weebl2000 force-pushed the fix/appservice-unstable-ephemeral-regression branch from e4a0734 to ee0b081 Compare July 13, 2026 11:56
@weebl2000
weebl2000 force-pushed the fix/appservice-unstable-ephemeral-regression branch from ee0b081 to 8ac9e5a Compare July 13, 2026 11:56
@weebl2000

Copy link
Copy Markdown
Contributor Author

Updated changelog.d filename to reference the PR rather than the issue.

@anoadragon453
anoadragon453 merged commit c93d523 into element-hq:develop Jul 13, 2026
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

legacy de.sorunome.msc2409.push_ephemeral flag no longer honored in appservice handler

4 participants