Ignore received EDUs if origin server in room ACL

[devonh]

Implements: MSC4163: Make ACLs apply to EDUs

Part of #18118 to declare support for Matrix v1.13

Complement PR: matrix-org/complement#783 -> matrix-org/complement#862

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Code style is correct (run the linters)

[MadLittleMods]

Looks good assuming Complement tests are ready to ship alongside and the tests pass here.

[MadLittleMods]

Previous discussion

Add a comment about copying because we mutate it below

[FrenchGithubUser]

Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you @sandhose and @devonh ? :)

[MadLittleMods]

Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you [...] ? :)

-- @FrenchGithubUser, #18475 (comment)

This PR appears close as-is (just needs one comment added) so I don't think creating a new PR is that useful. Getting the Complement side sorted sounds good as that's the main blocker here. Once the Complement tests are merged, we can just wrap up this PR ⏩

(better to comment on the diff so we can thread the discussion)

[MadLittleMods]

Tested to make sure COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh -run TestACLsForEDUs (test from matrix-org/complement#862) passes with this PR and fails on develop as expected

[MadLittleMods]

Complement failing with panic: BUG: Empty package name encountered.

For some reason, the Complement CI is failing with:

panic: BUG: Empty package name encountered.

goroutine 8 [running]:
github.com/gotesttools/gotestfmt/v2/parser.(*packageTracker).ensurePackage(...)
	/home/runner/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/parser/parse.go:220
github.com/gotesttools/gotestfmt/v2/parser.(*packageTracker).AddOutput(0xc000198dc0?, {0x0?, 0x2e?}, {0x0?, 0x0?}, {0xc00001f500?, 0x0?, 0x0?})
	/home/runner/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/parser/parse.go:192 +0x43c
github.com/gotesttools/gotestfmt/v2/parser.parse(0xc00001c380, 0xc00001c3f0, 0xc00001c460, 0xc00001c4d0, 0xc00001c540)
	/home/runner/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/parser/parse.go:133 +0x69f
created by github.com/gotesttools/gotestfmt/v2/parser.Parse in goroutine 1
	/home/runner/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/parser/parse.go:26 +0xea
cat: write error: Broken pipe

This is because the first lines of the output don't include "Package":"..." like the rest of the lines and gotestfmt chokes on parsing it.

{"ImportPath":"./tests/msc4222","Action":"build-output","Output":"# ./tests/msc4222\n"}
{"ImportPath":"./tests/msc4222","Action":"build-output","Output":"stat /home/runner/work/synapse/synapse/complement/tests/msc4222: directory not found\n"}
{"ImportPath":"./tests/msc4222","Action":"build-fail"}

Archive: 18475-72962188961-job-log.txt

If you download the archive, you can reproduce this locally by running: sed -n '3379,15707p' ~/Downloads/18475-72962188961-job-log.txt | sed 's/^[^ ]* //' | go run github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@v2.5.0 -hide "successful-downloads,successful-tests,empty-packages"

And if you skip those first 3 lines, things work: sed -n '3382,15707p' ~/Downloads/18475-72962188961-job-log.txt | sed 's/^[^ ]* //' | go run github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@v2.5.0 -hide "successful-downloads,successful-tests,empty-packages"

Why are we seeing /home/runner/work/synapse/synapse/complement/tests/msc4222: directory not found?

Not sure, matrix-org/complement -> tests/msc4222 on main still exists 🤔

Doesn't feel like it's anything related to this PR but it's consistent across runs and we're not seeing the same problem on develop

I bet this is because matrix-org/complement#783 existed with the same branch devon/acl-edus but that Complement branch is outdated and doesn't include tests/msc4222. We probably just need to delete that branch ⏩

This started failing because I merged in the latest develop here which brings in this update to include ./tests/msc4222 as a test package:

synapse/scripts-dev/complement.sh

Line 288 in 22e1643

./tests/msc4222

[MadLittleMods]

CI passed after deleting the devon/acl-edus branch in the Complement repo ✅