Verification | Unexpected verified badge in DM title bar on the other user avatar

[BillCarsonFr]

As a fresh user (eve) I created a DM with Alice.
I then noticed a verified badge on alice

I double check on the console, and Alice is not verified:

await mxMatrixClientPeg.get().getCrypto().getUserVerificationStatus("@alice:localhost")

UserVerificationStatus {needsUserApproval: false, crossSigningVerified: false, crossSigningVerifiedBefore: false, tofu: false}

If I refresh the browser tab it is then fixed.

Here is more details on the succession of events:

Maybe an outdated room shield? and some confusion between user badges and room shields?

[BillCarsonFr]

Found a similar out-of-date UX problem
Starts with Alice and Eve verified.
Let Eve reset it's identity

I then see the warning

Then reverify Eve from Alice side.
The Room header is out-of-date and still showing the red warning

switch to one room and come back. it is then up to date

[andybalaam]

Crypto team will put this on our backlog and do a timeboxed investigation of whether this is simple to fix.

[uhoreg]

The icon is handled by components/views/rooms/RoomHeader.tsx, which uses hooks/useEncryptionStatus.tsx to determine which icon to show, which only looks at the status at the time it is called. So, basically, it doesn't update the icon when the user identity changes, until the user switches rooms and switches back, causing it to re-render.

The solution would be to fix hooks/useEncryptionStatus.tsx to subscribe to some events, so that it updates the state when there are identity changes. I guess in this case, we would want to listen for CryptoEvent.UserTrustStatusChanged and RoomStateEvent.Events (to catch room membership changes). It may also involve picking through utils/ShieldUtils.tsx to determine if there are other events that we should listen for.

The icon from the initial comment was probably because the room was verified before Alice was invited/joined, and never got updated when Alice joined.

Probably a size S task.

[uhoreg]

Moving back to Qualification, now that we have an estimate.