ci: fix zizmor audit findings - #4200
Merged
Merged
Conversation
dsanders11
marked this pull request as ready for review
April 2, 2026 22:13
dsanders11
approved these changes
Apr 2, 2026
5 tasks
claude Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
Applies the GitHub Actions security hardening from #4200 (main) to the next branch's reworked workflows: - Add top-level least-privilege `permissions: {}` to ci.yml, release.yml and gh-pages.yml, with scoped `permissions:` on jobs that need write access (the release publish job's existing contents/id-token trusted publishing permissions are preserved). - Add `persist-credentials: false` to every actions/checkout step. - Avoid expression injection in the release step by passing the version through an environment variable. - Mark the add-to-project pull_request_target trigger with a zizmor dangerous-triggers ignore. - Add a dependabot cooldown (default-days: 7). Co-authored-by: Samuel Attard <sattard@anthropic.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
erickzhao
pushed a commit
that referenced
this pull request
Jul 2, 2026
Applies the GitHub Actions security hardening from #4200 (main) to the next branch's reworked workflows: - Add top-level least-privilege `permissions: {}` to ci.yml, release.yml and gh-pages.yml, with scoped `permissions:` on jobs that need write access (the release publish job's existing contents/id-token trusted publishing permissions are preserved). - Add `persist-credentials: false` to every actions/checkout step. - Avoid expression injection in the release step by passing the version through an environment variable. - Mark the add-to-project pull_request_target trigger with a zizmor dangerous-triggers ignore. - Add a dependabot cooldown (default-days: 7). Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Samuel Attard <sattard@anthropic.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes zizmor audit findings surfaced in the latest scheduled audit run.
Auto-fixes applied:
dependabot-cooldown: added 7-day default cooldown for github-actions updatesartipacked: addedpersist-credentials: falseto allactions/checkoutstepscache-poisoning: addedlookup-only: trueto ESLint cache steptemplate-injection: movedsteps.version.outputs.versioninto env var in release.ymlManual fixes:
excessive-permissions: added top-levelpermissions: {}block toci.yml,gh-pages.yml, andrelease.yml, plus minimalcontents: readjob-level grants where neededRemaining (low-confidence) findings:
cache-poisoningwarnings onactions/setup-nodecalls. These are flagged because the workflows are triggered by tag/branch pushes (publishing-style triggers). Inci.ymlthe cache is commented out, and ingh-pages.ymlyarn caching is needed for the docs build. These have low audit confidence and are accepted as known.cc @dsanders11