feat(template): use moduleResolution: bundler - #4175
Merged
Conversation
moduleResolution: bundler in tsconfig.json
moduleResolution: bundler in tsconfig.jsonmoduleResolution: bundler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref #4082 (comment)
In our TypeScript templates, applies
module: preserveandmoduleResolution: bundler.Vite-specific changes
forge-vite-env.d.tsso that it could be consumed by thetypesfield intsconfig.json.forge.env.d.tsin the template.BaseTemplateinitialization changesBaseTemplatenow merges allpackage.jsonfields from thetmplfolder. Effectively, this makes it more intuitive to pass template-specific configuration (instead of writing static strings into the package.json via JavaScript).Typechecker tests
I added a new
tsc --noEmitscript into each TypeScript template. This is used in a new test that validates that all the types are happy. :)Testing
yarn patchin a sample Vite app: tinyspeck/sleuth@fd24c7b