feat: expose artifact version to static publishers - #4033
Merged
Conversation
erikian
reviewed
Oct 20, 2025
| arch: makeResult.arch, | ||
| isReleaseFile: | ||
| path.basename(artifact, path.extname(artifact)) === 'RELEASES', | ||
| version: makeResult.packageJSON.version, |
Member
There was a problem hiding this comment.
question: it's technically valid for a package.json to have no version field and IIRC we don't check for its presence in any previous steps. Should this field be optional or is the assumption that anyone using a publisher is supposed to have a valid version good enough here?
Member
There was a problem hiding this comment.
Or maybe:
Suggested change
| version: makeResult.packageJSON.version, | |
| version: makeResult.packageJSON.version ?? '', |
Member
Author
There was a problem hiding this comment.
We definitely rely on the version field here for a lot of logic.
forge/packages/maker/dmg/src/MakerDMG.ts
Line 32 in 2914cd1
Maybe we should have better version propagation support but rn we just assume it's there everywhere and error in some cases if it's missing
erickzhao
reviewed
Oct 20, 2025
erickzhao
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: refactors
uploadOptionsin the GCS publisher to be more type-safe and a specific property instead of an unsafe rest param.