Added publisher and size shown in win uninstall

[demetris-manikas]

No description provided.

[mention-bot]

By analyzing the blame information on this pull request, we identified @stefanjudis, @radibit and @malept to be potential reviewers

[stefanjudis]

Can we add an example value here -> 200MB?
The sample file shows mostly concrete values over the place. :)

[demetris-manikas]

Replaced Estimated Size with a number. The units are KB as stated later on in the file.

[stefanjudis]

Just a tiny note - over all looking good. 👍

[demetris-manikas]

Any thoughts about adding
BrandingText "${APP_NAME} ${APP_VERSION}" to the template?
This way NullSoft Install System vX.XX.XXX in the (un)installer is replaced by the BrandingText value

[stefanjudis]

I'll do electron-builder night tonight. :)

Sorry for the huge delay. :(

[stefanjudis]

Any thoughts about adding BrandingText "${APP_NAME} ${APP_VERSION}" to the template?

Sounds perfect to me. :)

About the size - would be cool if we could automatically add the size, as we have the application available.

What do you think?

[demetris-manikas]

I found a method to add the size but I 'll have no Windows PC available for a while so I cannot test it.

It is described in http://nsis.sourceforge.net/Add_uninstall_information_to_Add/Remove_Programs Computing Estimated Size section.

Take a look. Looks quite straightforward to implement.

And... while you are there read the whole page.
There are quite a few uninstall options that are not implemented
The QuietUninstallString is very easy to implement along with some others (VersionMajor, VersionMinor).
Let me now what you think.

[demetris-manikas]

I managed to get hold of windows and tried it. Looks fine.

[stefanjudis]

@demetris-manikas can you please resolve conflicts... After that I'll give it a try.

Thanks a lot. :)

[demetris-manikas]

Conflicts resolved.

[demetris-manikas]

Hi, any news on this one?
I guess you are busy but I would appreciate some feedback.
Thanks.

[stefanjudis]

@demetris-manikas sorry it happened again. :(

There was an older PR than yours which I merged first. Sorry about that.

[demetris-manikas]

I guess you I have to resolve conflicts once more... not a problem for this one.

[demetris-manikas]

Conflicts resolved.

[stefanjudis]

👍 Tried it and works.