Skip to content

Cleanup changes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elcste merged 2 commits into from
Oct 20, 2025
Merged

Cleanup changes #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e1d86d
null out _settings
aves84 Oct 15, 2025
33d81c6
some cleanup changes
aves84 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default class HideCursor extends Extension {
enable() {
this._settings = this.getSettings()
this.HIDE_TIMEOUT = this._settings.get_int('timeout') * 1000
this._settings.connect('changed::timeout', () =>
this._settingsConnectionID = this._settings.connect('changed::timeout', () =>
this.HIDE_TIMEOUT = this._settings.get_int('timeout') * 1000)

this._seat = Clutter.get_default_backend().get_default_seat()
Expand All @@ -24,34 +24,43 @@ export default class HideCursor extends Extension {
this._tracker.disconnect(this._positionChangedId)
this._positionChangedId = null
}

if (this._settingsConnectionID) {
this._settings.disconnect(this._settingsConnectionID)
this._settingsConnectionID = null
}

if (this._tracker) {
this._tracker.uninhibit_cursor_visibility()
if (this._hasVisibilityInhibited && !this._tracker.get_pointer_visible())
this._tracker.uninhibit_cursor_visibility()
this._tracker = null
this._hasVisibilityInhibited = null
}

if (this._timer) {
GLib.Source.remove(this._timer)
this._timer = null
}

if (this._hasInhibited) {
if (this._hasFocusInhibited) {
this._seat.uninhibit_unfocus()
this._hasInhibited = false
this._hasFocusInhibited = null
}

this._seat = null
this._lastMove = null
this._settings = null
this.HIDE_TIMEOUT = null
}

tick = () => {
if (Date.now() - this._lastMove > this.HIDE_TIMEOUT && this._tracker.get_pointer_visible()) {
if (!this._hasInhibited) {
if (!this._hasFocusInhibited) {
this._seat.inhibit_unfocus()
this._hasInhibited = true
this._hasFocusInhibited = true
}
this._tracker.inhibit_cursor_visibility()
this._hasVisibilityInhibited = true
}

return GLib.SOURCE_CONTINUE
Expand All @@ -60,12 +69,14 @@ export default class HideCursor extends Extension {
move = () => {
this._lastMove = Date.now()

if (this._hasInhibited) {
if (this._hasFocusInhibited) {
this._seat.uninhibit_unfocus()
this._hasInhibited = false
this._hasFocusInhibited = false
}

if (!this._tracker.get_pointer_visible())
this._tracker.uninhibit_cursor_visibility()

this._hasVisibilityInhibited = false
}
}