Handle ChunkedEncodingError as a retryable transfer failure - #2173
Open
magnusrwn wants to merge 1 commit into
Open
Handle ChunkedEncodingError as a retryable transfer failure#2173magnusrwn wants to merge 1 commit into
magnusrwn wants to merge 1 commit into
Conversation
Treat requests ChunkedEncodingError like other transient read-side HTTP failures in HTTPAdapter.get. This keeps interrupted range downloads on the retryable path instead of the fatal generic exception path, allowing partial progress to be preserved and remaining bytes to be retried.
magnusrwn
requested review from
gbanasiak and
stevereads-elastic
and removed request for
a team
August 14, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2172.
Summary
requests.exceptions.ChunkedEncodingErrorraised while streamingHTTP response chunks was falling through to Rally's fatal generic
exception path. That caused the whole transfer to abort even when partial progress
had already been recorded.
This change treats
ChunkedEncodingErrorlike Rally's othertransient HTTP read failures in
HTTPAdapter.get(), so interruptedrange downloads stay on the retryable path and remaining bytes can be
retried.
Testing
tests/storage/http_test.pyto verifyChunkedEncodingErroris translated toTimeoutErrortests/storage/transfer_test.pyto verify partialprogress is preserved and remaining bytes stay in
todomake lint test