fix: allow file config to override true default values - #4119
Merged
Merged
Conversation
This allows a "false" boolean value to override a "true" default value when loading the options via the elastic-apm-node.js config file Fixes: elastic#4112 Closes: elastic#4112
Contributor
Author
|
How do I get someone to review this? |
david-luna
self-requested a review
July 30, 2024 15:19
Member
Hi @csnate, Sorry for the late reply. I triggered the CI to run the checks and bring up this PR in the planning for the next release :) |
david-luna
reviewed
Jul 30, 2024
PR feedback to update the name of the test and adding additional information to each assertion
david-luna
approved these changes
Jul 30, 2024
Member
|
run docs-build |
trentm
pushed a commit
that referenced
this pull request
Aug 1, 2024
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a "false" boolean value to override a "true" default value when loading the options via the elastic-apm-node.js config file
Fixes: #4112
Closes: #4112
Checklist