chore!: drop next@11 support - #3664
Merged
Merged
Conversation
next@11 does not get new releases, and only works on node 14 and 16, which are EOL. It is failing in our CI TAV tests and it is not worth the time digging into older versions.
Member
Author
|
cla/check |
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
david-luna
approved these changes
Oct 13, 2023
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
next@11 does not get new releases, and only works on node 14 and 16, which are EOL. It is failing in our CI TAV tests and it is not worth the time digging into older versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next@11 does not get new releases, and only works on node 14 and 16,
which are EOL. It is failing in our CI TAV tests and it is not worth
the time digging into older versions.
Currently
test-tav (next 14)andtest-tav (next 16), i.e. the TAV tests of Next.js with Node v14 and v16, are failing withnext@11. For example, from https://github.com/elastic/apm-agent-nodejs/actions/runs/6488426576/job/17620863144I don't know what changed or when exactly, but I propose that it isn't worth digging into this because:
'11.1.4': '2022-01-27T02:04:33.982Z',. (FWIW, the last next@12 release was'12.3.4': '2022-11-21T23:40:47.122Z',.)Instead, let's drop next@11 support, so our builds can go green.
This change also reduces the number of next@12 and 13 versions tested, because the
nextTAV tests have become too long:checklist