Skip to content

fix: since v3 we no longer have the extension in the archive name #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmicu merged 1 commit into from
Jan 27, 2025
Merged

fix: since v3 we no longer have the extension in the archive name #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ def get_ec_name_by_system():

# The core, from `2.7.0`, introduces the extension in the tarball name
# (e.g. `ec-windows-386.exe.tar.gz`, `ec-windows-arm.exe.tar.gz`)
Comment thread
mmicu marked this conversation as resolved.
_ext = '.exe' if _system == 'Windows' else ''
# In `3.1.0` the windows extension was then again dropped from the
# archive name.

return 'ec-{}-{}{}'.format(
return 'ec-{}-{}'.format(
_system.lower(),
_architecture,
_ext,
)

return 'https://github.com/editorconfig-checker/editorconfig-checker/releases/download/{}/{}.tar.gz'.format(
Expand Down