feat: first updated esds communication KIT. - #1555
Conversation
- Introduced a new category for the eSDScom KIT in sidebarsDocsKits.js with links to its changelog and views. - Added the eSDScom KIT logo as an SVG file along with its licensing information. - Updated the generated kit navigation items to include the eSDScom KIT with its corresponding route.
matbmoser
left a comment
There was a problem hiding this comment.
So I have supported you on finding a logo and setting up the KIT structure correctly.
I did not changed any content from the KIT since this is something that I would expect you to do (Since you know more than me)
However I have provided some feedback as an external adopter, and also added some points which normally other KITs are also doing.
I feel that is missing some "valuable" content description here, like some JSON payloads for example. I see the model is not published so I would recommend you to add it here.
I know it is long, but it would bring value if it is at least organized in sections with each payload being available to be seen in JSON format.
You can use <details> tags to hide the payloads so it is easier to read if the files are too big. I have provided some examples how to do it. You can even include it inside code blocks from Markdown.
|
|
||
| ### Core Semantic Models | ||
|
|
||
| [io.catenax.esdscom 1.0.0 extended Safety Data Sheet communication](https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.esdscom/1.0.0) |
There was a problem hiding this comment.
This link does not exists! There is no published datamodel, and if it would be published this would not be the url.
There was a problem hiding this comment.
Since this model is not published feel free to add it here:
<details>
<summary><strong>Catena-X Safety Datasheet Model Payload</summary>
Add your model here:
...
</details>
| "leftOperand": "UsagePurpose", | ||
| "operator": "isAnyOf", | ||
| "rightOperand": [ | ||
| "cx.esdscom.base:1" |
There was a problem hiding this comment.
is this aligned with the Expert Group from data sovereignty? @DanielaWuensch
There was a problem hiding this comment.
Not sure if this is how we should reference.
There was a problem hiding this comment.
Was aligned with Daniela Wuensch.
Mail von Freitag, 10. April 2026:
"Hallo Dirk, hallo Anita,
Die Änderung in CX-0152 zum eSDScom purpose sind in diesem PR an dieser Stelle:
bereit für den Review. Darauf könnt ihr euch dann mit dem rightOperand cx.esdscom.base:1 des Usage Purpose beziehen.
Viele Grüße,
Daniela"
|
|
||
| ## Tutorials & Resources | ||
|
|
||
| Not yet available. |
There was a problem hiding this comment.
If you dont have tutorials just remove it.
| ### Model Example | ||
|
|
||
| Due to the model size, for further information please refer to [esdscom.eu](https://esdscom.eu) | ||
|
|
There was a problem hiding this comment.
We could add an example here if you would like, that would give some quality to the documentation.
feel free to add it like this, so it gets "hidden" in a dropdown:
<details>
<summary><strong>XML Safety Datasheet Model</summary>
Add your model here:
...
</details>
There was a problem hiding this comment.
@dirk-qualisys : Could you please add the draft model or the XML here?
|
@copilot please find typos |
|
Please review if the KIT logo is correct and you like it. Added a random color, since this is a different use case than "just sustainability". |
|
Policy is correct just confirmed with the DataSov EG. Not sure if we should use Neptune 2026/09/ in the context from json-ld. |
| "https://w3id.org/catenax/2025/9/policy/odrl.jsonld", | ||
| "https://w3id.org/catenax/2025/9/policy/context.jsonld" |
There was a problem hiding this comment.
This is where I meant. @jSchuetz88 is possible to use 2026 here?
|
@matbmoser : we try to eliminate the errors within the ticket but cannot edit. Can you please advice us, how to fork this repository, so that we can work in it? |
ok normally Andrew could edit its own branch in the fork |
|
I can apply at least the suggestions I have done. |
|
@Andrew96897 I have applied the edit to the points I have told. The only thing that is missing is to add the data models. @hillmer adding the data models is something that I cant do. I have requested the KIT master builder to do a check for typos and final quality checks. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| ### Changed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Removed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Nothing yet | ||
|
|
||
| ### Security | ||
|
|
||
| - Nothing yet |
| "leftOperand": "UsagePurpose", | ||
| "operator": "isAnyOf", | ||
| "rightOperand": [ | ||
| "cx.esdscom.base:1" |
|
|
||
| Model: eSDScom | ||
| Version: 1.0.0 | ||
| Namespace: urn:samm:io.catenax.eSDScom:1.0.0 |
| #### Standards | ||
|
|
||
| Technical standards and protocol compliance are not applicable. | ||
|
|
||
| #### Tutorials | ||
|
|
||
| Developer quick-start guides and code examples are not yet available. |
There was a problem hiding this comment.
| #### Standards | |
| Technical standards and protocol compliance are not applicable. | |
| #### Tutorials | |
| Developer quick-start guides and code examples are not yet available. |
I would take this out, because it does not adds value.
semantic model part updated
|
what is the latest state from this pr |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (6)
data/kitsData.js:481
- The logo SVG contains an explicit “Uploaded to: SVG Repo” marker, but the master data license block doesn’t provide
originalSourceUrl(supported by the schema) to reference the original third-party source. For TRG 7.07 third-party attribution, please addoriginalSourceUrlpointing to the exact SVG Repo asset page (and keepsourceUrlas the repository copy).
logoLicencse: {
type: 'CC-BY-4.0',
authors: '2026 eSDScom Workgroup and contributors; 2026 Catena-X Automotive Network e.V.; 2026 Contributors to the Eclipse Foundation',
licenseUrl: 'https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/blob/main/static/img/kits/esdscom-kit/esdscom-kit-raw-logo.svg.license',
sourceUrl: 'https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/blob/main/static/img/kits/esdscom-kit/esdscom-kit-raw-logo.svg'
static/img/kits/esdscom-kit/esdscom-kit-raw-logo.svg.license:6
- The
.licensesidecar is missing the eSDScom Workgroup attribution even thoughdata/kitsData.jslists it in the authors. Also, since the SVG indicates it was sourced from SVG Repo, TRG 7.07 third-party attribution expects the original source URL (and ideally author) to be captured (either here or viaoriginalSourceUrlin master data).
- SPDX-License-Identifier: CC-BY-4.0
- SPDX-FileCopyrightText: 2026 Contributors to the Eclipse Foundation
- SPDX-FileCopyrightText: 2026 Catena-X Automotive Network e.V.
- Source URL: https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/blob/main/static/img/kits/esdscom-kit/esdscom-kit-raw-logo.svg
docs-kits/kits/esdscom-kit/adoption-view/adoption-view.md:9
- The copyright header uses
Copyright(c)without a space. TRG 7.02 recommends the canonical formatCopyright (c) <year> ...for consistency across the repo.
<!--
Copyright(c) 2026 Contributors to the Eclipse Foundation
docs-kits/kits/esdscom-kit/development-view/development-view.md:9
- The copyright header uses
Copyright(c)without a space. TRG 7.02 recommends the canonical formatCopyright (c) <year> ...for consistency across the repo.
<!--
Copyright(c) 2026 Contributors to the Eclipse Foundation
docs-kits/kits/esdscom-kit/changelog.md:9
- The copyright header uses
Copyright(c)without a space. TRG 7.02 recommends the canonical formatCopyright (c) <year> ...for consistency across the repo.
<!--
Copyright(c) 2025 Contributors to the Eclipse Foundation
docs-kits/kits/esdscom-kit/development-view/development-view.md:54
- This section still contains a placeholder standard identifier (
CX-XXXX). Shipping placeholders in KIT docs is confusing for readers and makes the compliance requirements ambiguous.
To participate in the eSDScom use case, the following single standard MUST be fulfilled only by data providers:
- CX-XXXX eSDScom In the Catena-X technical landscape, the standard assumes the use of CX-0126-IndustryCorePartType.
The architecture follows a pull-based pattern: data is pushed from supplier to consumer (or other way around) but made accessible by the data provider. This standard applies equally to Data Providers and Consumers. All parties involved in the exchange must implement the agreed data structure and access patterns to ensure interoperability within the Catena-X network.
| type: 'category', | ||
| label: 'eSDScom KIT', | ||
| link: { type: 'generated-index' } | ||
| collapsed: true, |
|
Status: We need support in the github topics for creating this PR. There are several comments which we do not understand, Until now the status is that we wait for the data model release and continue afterwards |
matbmoser
left a comment
There was a problem hiding this comment.
I just confirmation from @jSchuetz88 that your standard will be the CX-0162 I will add it here already.
|
|
||
| To participate in the eSDScom use case, the following single standard MUST be fulfilled only by data providers: | ||
|
|
||
| - CX-XXXX eSDScom In the Catena-X technical landscape, the standard assumes the use of CX-0126-IndustryCorePartType. |
There was a problem hiding this comment.
| - CX-XXXX eSDScom In the Catena-X technical landscape, the standard assumes the use of CX-0126-IndustryCorePartType. | |
| - CX-0162 eSDScom In the Catena-X technical landscape, the standard assumes the use of CX-0126-IndustryCorePartType. |
There was a problem hiding this comment.
Ok I just saw two very important things which were wrong with the content. @Andrew96897 @hillmer
| - CX-XXXX eSDScom In the Catena-X technical landscape, the standard assumes the use of CX-0126-IndustryCorePartType. | ||
| The architecture follows a pull-based pattern: data is pushed from supplier to consumer (or other way around) but made accessible by the data provider. This standard applies equally to Data Providers and Consumers. All parties involved in the exchange must implement the agreed data structure and access patterns to ensure interoperability within the Catena-X network. | ||
|
|
||
| 1. All Identification and Access Management (IAM) follows the CX-0015 IAM & Access Control Paradigm for users and Clients standard [https://catenax-ev.github.io/docs/standards/CX-0015-IAMandAccessControlParadigmForUsersAndClients] which lays out the principles for both, data providers and data consumers. |
There was a problem hiding this comment.
Just a quick modification that I have just saw which is wrong:
| 1. All Identification and Access Management (IAM) follows the CX-0015 IAM & Access Control Paradigm for users and Clients standard [https://catenax-ev.github.io/docs/standards/CX-0015-IAMandAccessControlParadigmForUsersAndClients] which lays out the principles for both, data providers and data consumers. | |
| 1. All Data Exchange Requirements follows the CX-0018 Dataspace Connectivity [https://catenax-ev.github.io/docs/standards/CX-0018-DataspaceConnectivity] and which lays out the principles for both, data providers and data consumers. More information can be found in the [Connector KIT](https://eclipse-tractusx.github.io/docs-kits/kits/connector-kit/adoption-view). |
The IAM principal works different in Catena-X it is only valid for the portal, not for the data exchange, so we are not authenticating using Keycloak the data exchange, but rather using the CX-0018 standard which is core.
| 1. All Identification and Access Management (IAM) follows the CX-0015 IAM & Access Control Paradigm for users and Clients standard [https://catenax-ev.github.io/docs/standards/CX-0015-IAMandAccessControlParadigmForUsersAndClients] which lays out the principles for both, data providers and data consumers. | ||
| 2. Both, the data providers and consumers shall be identified in the Catena-X dataspace following the CX-0010 Business Partner Number Standard [https://catenax-ev.github.io/docs/standards/CX-0010-BusinessPartnerNumber] so that a clear identification of both parties enables automatic data exchange. | ||
| The Onboarding of the parties on the Catena-X Dataspace shall be effectuated following the CX-0006 Registration and initial Onboarding standard [https://catenax-ev.github.io/docs/standards/CX-0006-RegistrationAndInitialOnboarding]. | ||
|
|
There was a problem hiding this comment.
| 3. The data provider party must have a digital twin registry which comply with the [CX-0002](https://catenax-ev.github.io/docs/standards/CX-0002-DigitalTwinsInCatenaX) standard, detailed in the [Digital Twin KIT](https://eclipse-tractusx.github.io/docs-kits/kits/digital-twin-kit/adoption-view). In this way the eSDScom data model can be provided in a AAS Shell Descriptor as a Submodel, more information in the [development view](./development-view/development-view.md). |
|
After this clarification I can merge. |
Description
[ADDED BY MATHIAS]
This is like the kit logo looks like:
From sideways:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: