Fixed exeternal prefix cleaning#61
Merged
AlexanderLanin merged 2 commits intoeclipse-score:mainfrom Jun 3, 2025
Merged
Conversation
Fixing external prefix cleaning Adding tests via RST files Changing metamodel to allow for tests
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaximilianSoerenPollak
requested review from
AlexanderLanin,
Aymen-Soussi-01,
dcalavrezo-qorix,
mmr1909 and
nicu1989
dcalavrezo-qorix
approved these changes
Jun 3, 2025
| #CHECK: check_options | ||
|
|
||
| .. Cleaning of 'external prefix' before checking regex confirmity | ||
| #EXPECT-NOT tool_req__test_abcd.satisfies (PROCESS_doc_getstrt__req__process): does not follow pattern `^doc_.+$`. |
Contributor
Author
There was a problem hiding this comment.
Testing the positive case is not possible (only via unittests maybe) as if the 'external link' does not exists the links do not get passed along to the check (probably something sphinx-needs internal).
So you only get the message that the link is not good, but not the error you are actually looking for.
Comment on lines
-80
to
+83
| if field_type == "link" and allowed_prefixes: | ||
| values = remove_prefix(values, allowed_prefixes) | ||
|
|
||
| for value in values: | ||
| if field_type == "link" and allowed_prefixes: | ||
| value = remove_prefix(value, allowed_prefixes) |
Contributor
Author
There was a problem hiding this comment.
Issue was that if a list was passed into it, instead of removing all valued prefixes it just did the first value.
Member
There was a problem hiding this comment.
Should have been caught by basedpyright?!
AlexanderLanin
approved these changes
Jun 3, 2025
github-project-automation
Bot
moved this from Todo
to Done
in INF - Infrastructure Community
arnoox
pushed a commit
to arnoox/score-docs-as-code
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing external prefix cleaning
Adding tests via RST files
Changing metamodel to allow for tests