ci: Test devcontainer image with repos#118
Conversation
I am always afraid that devcontainer internal tests do not catch everything. With these tests it is assured that bazel build and test for selected repos and revisions works and stays working.
|
Nice feature but can you also document that in the readme?! |
AlexanderLanin
left a comment
There was a problem hiding this comment.
We do the same in docs-as-code. We've decided to call it consumer tests. On every PR we run half a dozen consumers with the PR version. This takes ~10 minutes, but it has saved us sooooooooooooo much trouble.
First thought was yeah!!! But on second thought... we never document workflows anywhere. Maybe a comment on top of the yml file? It would also be a lot more self explanatory with separate workflows? |
ok, for consistency I will rename it to consumer tests
That will be very tricky, because building a container image takes a lot of time. In the current approach the image is build once, tested and if tests pass, published. If I want to avoid building the image more than once, I need to save it somehow and share it among workflows. I do not know if that is easily possible.
At some point it may make sense to trim down the README.md and move sections into separate files. I think the label is definitely something needing documentation. |
opajonk
left a comment
There was a problem hiding this comment.
I like it!
The label stuff not triggering the label event... sounds like a bug. But nothing we can fix.
In other cases this worked. However there the label was evaluated directly in the jobs if condition. Maybe Github scans for that |
I am always afraid that devcontainer internal tests do not catch everything. Thus build the devcontainer locally and test it at multiple repositories, which is quite time consuming.
With these tests it is assured that bazel build and test for selected repos and revisions work and stay working.