Skip to content

ci: Test devcontainer image with repos#118

Merged
lurtz merged 6 commits intoeclipse-score:mainfrom
elektrobit-contrib:test-devcontainer-image-with-external-repos
May 7, 2026
Merged

ci: Test devcontainer image with repos#118
lurtz merged 6 commits intoeclipse-score:mainfrom
elektrobit-contrib:test-devcontainer-image-with-external-repos

Conversation

@lurtz
Copy link
Copy Markdown
Contributor

@lurtz lurtz commented May 6, 2026

I am always afraid that devcontainer internal tests do not catch everything. Thus build the devcontainer locally and test it at multiple repositories, which is quite time consuming.

With these tests it is assured that bazel build and test for selected repos and revisions work and stay working.

lurtz added 3 commits May 6, 2026 15:56
I am always afraid that devcontainer internal tests do not catch everything. With these tests it is assured that bazel build and test for selected repos and revisions works and stays working.
@lurtz lurtz marked this pull request as ready for review May 7, 2026 09:04
@lurtz lurtz requested a review from opajonk as a code owner May 7, 2026 09:04
@FScholPer
Copy link
Copy Markdown

Nice feature but can you also document that in the readme?!

AlexanderLanin
AlexanderLanin previously approved these changes May 7, 2026
Copy link
Copy Markdown
Member

@AlexanderLanin AlexanderLanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do the same in docs-as-code. We've decided to call it consumer tests. On every PR we run half a dozen consumers with the PR version. This takes ~10 minutes, but it has saved us sooooooooooooo much trouble.

@AlexanderLanin
Copy link
Copy Markdown
Member

Nice feature but can you also document that in the readme?!

First thought was yeah!!! But on second thought... we never document workflows anywhere. Maybe a comment on top of the yml file?

It would also be a lot more self explanatory with separate workflows?

@lurtz
Copy link
Copy Markdown
Contributor Author

lurtz commented May 7, 2026

We do the same in docs-as-code. We've decided to call it consumer tests. On every PR we run half a dozen consumers with the PR version. This takes ~10 minutes, but it has saved us sooooooooooooo much trouble.

ok, for consistency I will rename it to consumer tests

It would also be a lot more self explanatory with separate workflows?

That will be very tricky, because building a container image takes a lot of time. In the current approach the image is build once, tested and if tests pass, published.

If I want to avoid building the image more than once, I need to save it somehow and share it among workflows. I do not know if that is easily possible.

Nice feature but can you also document that in the readme?!

At some point it may make sense to trim down the README.md and move sections into separate files. I think the label is definitely something needing documentation.

AlexanderLanin
AlexanderLanin previously approved these changes May 7, 2026
@lurtz lurtz added the test-consumer Enable additional tests building consumers of this repository label May 7, 2026
FScholPer
FScholPer previously approved these changes May 7, 2026
@lurtz lurtz added test-consumer Enable additional tests building consumers of this repository and removed test-consumer Enable additional tests building consumers of this repository labels May 7, 2026
@lurtz lurtz dismissed stale reviews from FScholPer and AlexanderLanin via 76781f6 May 7, 2026 11:09
@lurtz lurtz enabled auto-merge May 7, 2026 11:21
Copy link
Copy Markdown
Contributor

@opajonk opajonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

The label stuff not triggering the label event... sounds like a bug. But nothing we can fix.

@lurtz lurtz added this pull request to the merge queue May 7, 2026
@lurtz
Copy link
Copy Markdown
Contributor Author

lurtz commented May 7, 2026

I like it!

The label stuff not triggering the label event... sounds like a bug. But nothing we can fix.

In other cases this worked. However there the label was evaluated directly in the jobs if condition. Maybe Github scans for that

Merged via the queue into eclipse-score:main with commit f2ee44b May 7, 2026
6 checks passed
@lurtz lurtz deleted the test-devcontainer-image-with-external-repos branch May 7, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-consumer Enable additional tests building consumers of this repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants