Skip to content

Added fields to envd stat/list method response - #745

Merged
jakubno merged 31 commits into
envd-extra-fields-for-file-methods-e2b-2767from
envd-stat-added-fields
Jul 24, 2025
Merged

Added fields to envd stat/list method response#745
jakubno merged 31 commits into
envd-extra-fields-for-file-methods-e2b-2767from
envd-stat-added-fields

Conversation

@mishushakov

@mishushakov mishushakov commented Jun 7, 2025

Copy link
Copy Markdown
Member
  • Added fields such as size, mode, permissions, owner, group, modified time to file stat and list response
  • Added test for stat method
  • Updated tests for list
  • Checks SDK version to prevent breaking (specifically Python)

This is an updated PR in favour of #655 which was reversed due to breaking Python SDK

@mishushakov mishushakov self-assigned this Jun 7, 2025
@mishushakov mishushakov added the improvement Improvement for current functionality label Jun 7, 2025
@mishushakov mishushakov changed the title Added fields to envd stat method response Added fields to envd stat/list method response Jun 7, 2025
@mishushakov

Copy link
Copy Markdown
Member Author

I tested this with current Python SDK

Comment thread packages/envd/internal/services/filesystem/utils.go Outdated
Comment thread packages/envd/internal/services/filesystem/utils.go Outdated
@mishushakov

mishushakov commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

I have changed the comparison logic: it will include all fields by default, expect when sdkLanguage is provided: python and higher than or equal to supported version

@mishushakov
mishushakov requested review from dobrac and jakubno June 27, 2025 19:27
@jakubno
jakubno changed the base branch from main to envd-extra-fields-for-file-methods-e2b-2767 July 24, 2025 10:03
@jakubno
jakubno force-pushed the envd-stat-added-fields branch from 4f76020 to 6d655e7 Compare July 24, 2025 10:15
@jakubno
jakubno merged this pull request into envd-extra-fields-for-file-methods-e2b-2767 Jul 24, 2025
@jakubno
jakubno deleted the envd-stat-added-fields branch July 24, 2025 10:15
jakubno added a commit that referenced this pull request Jul 24, 2025
Co-authored-by: Jakub Novak <jakub@e2b.dev>
jakubno added a commit that referenced this pull request Jul 25, 2025
Co-authored-by: Mish Ushakov <10400064+mishushakov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants