Skip to content

xWebApplication: Update descriptions in class xWebApplicationAuthenticationInformation - #528

Merged
johlju merged 5 commits into
dsccommunity:devfrom
omiossec:xWebApplicationAuthenticationInformation_missing_description
Oct 7, 2019
Merged

xWebApplication: Update descriptions in class xWebApplicationAuthenticationInformation#528
johlju merged 5 commits into
dsccommunity:devfrom
omiossec:xWebApplicationAuthenticationInformation_missing_description

Conversation

@omiossec

@omiossec omiossec commented Oct 6, 2019

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

xWebApplication: Missing descriptions on class MSFT_xWebApplicationAuthenticationInformation
change in MSFT_xWebApplication.schema.mof

This Pull Request (PR) fixes the following issues

Task list

  • [x ] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io

codecov-io commented Oct 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #528 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #528   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e06302...540126f. Read the comment docs.

@johlju johlju added the needs review The pull request needs a code review. label Oct 7, 2019

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Oct 7, 2019
@johlju johlju changed the title change in xWebApplicationAuthenticationInformation xWebApplication: Update description in class xWebApplicationAuthenticationInformation Oct 7, 2019
@johlju johlju changed the title xWebApplication: Update description in class xWebApplicationAuthenticationInformation xWebApplication: Update descriptions in class xWebApplicationAuthenticationInformation Oct 7, 2019

@johlju johlju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
johlju merged commit ca6a6bc into dsccommunity:dev Oct 7, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Oct 7, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
…cationInformation (dsccommunity#528)

- Changes to xWebApplication
  - Add description on class MSFT_xWebApplicationAuthenticationInformation (issue dsccommunity#454).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xWebApplication: Missing descriptions on class MSFT_xWebApplicationAuthenticationInformation

4 participants