xIisLogging: Moving strings to localization file - #510
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #510 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 17 17
Lines 2661 2661
=======================================
Hits 2432 2432
Misses 229 229
Continue to review full report at Codecov.
|
johlju
left a comment
There was a problem hiding this comment.
Just tiny comments. Please make sure to update the other PR's of yours similar.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Outek)
a discussion (no related file):
Please update the CHANGELOG.md with an entry explaining this change.
DSCResources/MSFT_xIisLogging/MSFT_xIisLogging.psm1, line 29 at r1 (raw file):
$LocalizedData
Please update all references to $script:localizedData.
Outek
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @johlju)
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Please update the CHANGELOG.md with an entry explaining this change.
Done.
DSCResources/MSFT_xIisLogging/MSFT_xIisLogging.psm1, line 29 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
$LocalizedDataPlease update all references to
$script:localizedData.
Done.
johlju
left a comment
There was a problem hiding this comment.
Just another tiny comment 🙂
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Outek)
CHANGELOG.md, line 6 at r2 (raw file):
Moved MSFT_xIisLogging localization strings to strings.psd1.
Please move this under - Changes to xIISLogging.
johlju
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Outek)
CHANGELOG.md, line 6 at r2 (raw file):
Moved MSFT_xIisLogging localization strings to strings.psd1.
Please also update with the correct issue (see other entries for example)
Outek
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @johlju)
CHANGELOG.md, line 6 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Moved MSFT_xIisLogging localization strings to strings.psd1.Please move this under
- Changes to xIISLogging.
Done.
CHANGELOG.md, line 6 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Moved MSFT_xIisLogging localization strings to strings.psd1.Please also update with the correct issue (see other entries for example)
Done.
johlju
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
- Changes to xIisLogging - Moved MSFT_xIisLogging localization strings to strings.psd1 (issue dsccommunity#464).
Pull Request (PR) description
xIisLogging: Moving strings to localization file
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is