Security Fix: Potential XSS Vulnerability in stripXss function - #187
Open
scyt01 wants to merge 1 commit into
Open
Security Fix: Potential XSS Vulnerability in stripXss function#187scyt01 wants to merge 1 commit into
scyt01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential vulnerability in the stripXss() function in XssSqlUtil.java that could lead to Cross-Site Scripting (XSS) attacks because it does not use the ESAPI library for canonicalization which leaves it vulnerable to encoded attacks. This issue was originally reported and resolved in the repository via this commit logicaldoc/community@739b005.
Fix
Add Canonicalization
Include Additional Regex Patterns
References
CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-Site Scripting')
CWE-116: Improper Encoding or Escaping of Output
logicaldoc/community@739b005