Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
======================================
Coverage 94.0% 94.0%
======================================
Files 22 23 +1
Lines 1619 1637 +18
======================================
+ Hits 1522 1540 +18
Misses 97 97
|
jayqi
left a comment
There was a problem hiding this comment.
Do we correctly handle percent-encoded colons from a drive on Windows? e.g.,
file://c:/path/to/file.txt vs. file://c%3A/path/to/file.txt
We should at least have a test for it.
See this PR AcademySoftwareFoundation/OpenTimelineIO#1664
that also referenced the cpython issue that you took this implementation from. They discuss the issue in that PR and have a Windows test case.
I tried to search around, and I found this which suggests that the percent-encoded version should be considered valid: https://github.com/microsoft/language-server-protocol/pull/1786/files
|
Updated, thanks @jayqi! |
Simple implementation of
file:scheme inAnyPath.Uses implementation from here, but it looks like there is a
from_urimethod coming topathlibin 3.13.Closes #401