Conversation
Contributor
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 91.5% 91.5%
=======================================
Files 11 18 +7
Lines 839 1034 +195
=======================================
+ Hits 768 947 +179
- Misses 71 87 +16
|
Member
Author
|
@pjbull I think this is ready for review! |
jayqi
commented
Nov 15, 2020
Member
Author
|
@pjbull I rebased this PR and added support for the new GS classes. |
pjbull
approved these changes
Jan 25, 2021
Member
pjbull
left a comment
There was a problem hiding this comment.
🎉
Would be good to add a bullet to "why cloudpathlib" at the top of the readme that says something like "Testability: We provide Local* classes that can be used to easily mock cloud storage in your unit tests."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalPathandLocalClientthat use the local filesystem as "cloud" storage.LocalAzureBlobClient,LocalAzureBlobPath,LocalS3Client,LocalS3Paththat are intended to be monkeypatch substitutes for testing (UPDATE: +LocalGSClient,LocalGSPath)"Testing with cloudpathlib""Testing code that uses cloudpathlib" with examples of how to patch things for testsResolves #106