Fixed parsing of illegal dates + handle known null value - #650
Merged
Conversation
drewnoakes
approved these changes
Feb 4, 2024
drewnoakes
left a comment
drewnoakes
left a comment
Owner
There was a problem hiding this comment.
This looks great, thanks.
Running your branch over the regression test data doesn't show any difference. Is there an image that triggers this for you that we can add for testing? The content of the image is not important, just the metadata.
Contributor
Author
|
@drewnoakes Yes, I attached on the original issue a JPG test image you are free to use in your repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem that parsing a date like
0000:00:00 00:00:00will becomeSun Nov 30 00:00:00 GMT 2.Resolves #609.