Add support for Develco External Meter Interface ZHEMI101 - #4426
Merged
Conversation
Required for appropriately configuring the device
manup
reviewed
Feb 22, 2021
- Typo correction - Comment interfaces modes - Correct error message on disallowed interface modes - Improve type handling while writing attributes
manup
reviewed
Mar 3, 2021
manup
reviewed
Mar 25, 2021
manup
left a comment
manup
left a comment
Member
There was a problem hiding this comment.
Had a closer look, no errors but might be worth considering these changes.
- Add defines for interface values - Add additional error handling - Stricter check on API provided pulse configuration values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested and working.
Introduce
RConfigPulseConfigurationandRConfigInterfaceModeto API