Skip to content

chore(deps): upgrade go-github to v89 and update client initialization - #4878

Merged
gaius-qi merged 1 commit into
dragonflyoss:mainfrom
chimanjain:upgr-go-github
Jul 21, 2026
Merged

chore(deps): upgrade go-github to v89 and update client initialization#4878
gaius-qi merged 1 commit into
dragonflyoss:mainfrom
chimanjain:upgr-go-github

Conversation

@chimanjain

@chimanjain chimanjain commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

  • Upgrades the go-github from v17 (incompatible) to v89.
  • Updated GitHub client initialization to use github.WithHTTPClient() option pattern (v89+ API change) with proper error handling.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.12%. Comparing base (cba0bbb) to head (c0ea38d).

Files with missing lines Patch % Lines
manager/auth/oauth/github.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4878      +/-   ##
==========================================
- Coverage   28.12%   28.12%   -0.01%     
==========================================
  Files         232      232              
  Lines       23158    23160       +2     
==========================================
  Hits         6513     6513              
- Misses      16197    16199       +2     
  Partials      448      448              
Flag Coverage Δ
unittests 28.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/auth/oauth/github.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi added the enhancement New feature or request label Jul 21, 2026
@gaius-qi
gaius-qi enabled auto-merge (squash) July 21, 2026 02:58
@gaius-qi
gaius-qi merged commit 798c489 into dragonflyoss:main Jul 21, 2026
18 of 19 checks passed
@chimanjain
chimanjain deleted the upgr-go-github branch July 21, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants