Skip to content

Allow printing ADB path using xharness android state --adb - #724

Merged
premun merged 1 commit into
dotnet:mainfrom
premun:prvysoky/adb
Sep 30, 2021
Merged

Allow printing ADB path using xharness android state --adb#724
premun merged 1 commit into
dotnet:mainfrom
premun:prvysoky/adb

Conversation

@premun

@premun premun commented Sep 29, 2021

Copy link
Copy Markdown
Member

Needed for dotnet/arcade#7970 and for dotnet performance tests

Also drops "Get" from "*GetDevice" and "*GetState" commands to follow the rest of the commandset

@premun
premun requested review from MattGal and billwert September 29, 2021 14:23

@MattGal MattGal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem like a lot for what's happening here, especially given in the debug logging level it already logs where the exe is all the time. (You also changed mac stuff unrelated to the title of the PR?)

Why not just expose the path on Adbrunner like you have, and just log it in

, without all the rest of this?

Comment thread src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs

@MattGal MattGal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I get the use case now after discussing with @premun . It may be more useful to just have a command that calls ADB and prints its output unfiltered by the log, but signing off so this can be used in the mean time.

@premun
premun merged commit 63e5171 into dotnet:main Sep 30, 2021
@premun
premun deleted the prvysoky/adb branch September 30, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants