Skip to content

Do not escape no-break space (\u00A0)#4267

Merged
bekir-ozturk merged 6 commits into
mainfrom
dev/bozturk/loc-tool-symbol-encoding
Jan 21, 2022
Merged

Do not escape no-break space (\u00A0)#4267
bekir-ozturk merged 6 commits into
mainfrom
dev/bozturk/loc-tool-symbol-encoding

Conversation

@bekir-ozturk

Copy link
Copy Markdown

Problem

Fixes #4243

Solution

Creates a new javascript encoder to allow \u00A0 character to be not escaped.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ? (nullability is enabled project-wide)

Comment thread src/Microsoft.TemplateEngine.TemplateLocalizer.Core/TemplateStringUpdater.cs Outdated
@bekir-ozturk
bekir-ozturk merged commit 7824133 into main Jan 21, 2022
@bekir-ozturk
bekir-ozturk deleted the dev/bozturk/loc-tool-symbol-encoding branch January 21, 2022 13:08
ladipro added a commit to dotnet/arcade that referenced this pull request Feb 1, 2022
…tnet/winforms) (#8395)

Moving to latest version of the package in order to consume dotnet/templating#4267. This unblocks adoption of the template localizer in the winforms repo. See dotnet/winforms#6319 (comment) for context on the bug being fixed.
ghost pushed a commit to dotnet/winforms that referenced this pull request Feb 4, 2022
PR reenables template localization disabled in #6441
Issue was fixed in dotnet/templating#4267 and available in latest version of arcade dotnet/arcade#8395.
verdie-g pushed a commit to verdie-g/sdk that referenced this pull request Jul 16, 2026
* Don't update loc files if there is no meaningful change

* Added test for unchanged loc files

* Don't escape no-break space.

* Test fixes

* Move collection comparison to a new method

* Improve comments

Commit migrated from dotnet/templating@7824133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template localizer changes encoding of some characters

3 participants