Migrate Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests to MSTest.Sdk on MTP by Evangelink · Pull Request #54862 · dotnet/sdk

Evangelink · 2026-06-18T12:56:31Z

Migrates Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests from xUnit to MSTest.Sdk on MTP.

Depends on #54845 (foundation) and #54861 (BlazorWebAssembly.Tests) — it link-compiles WasmPublishIntegrationTestBase / BootJsonData / ServiceWorkerAssert from the Blazor tests, so this branch is stacked on that one. Merge after both. Compiles clean locally.

…n MTP Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

…undation' into evangelink/mstest-mtp-blazoraot-tests

Resolves conflicts in StaticWebAssets test files and converts newly merged xUnit-style tests/attributes from main to MSTest: - [Fact] -> [TestMethod]; added [TestClass] (+ [DoNotParallelize] for CWD-mutating MT tests) - [PlatformSpecificFact(TestPlatforms.X)] / [PlatformSpecific(...)] -> [TestMethod] + [OSCondition(...)] - [WindowsOnlyRequiresMSBuildVersion(v)] -> [OSCondition(OperatingSystems.Windows)] + [RequiresMSBuildVersion(v)] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Evangelink · 2026-06-20T07:43:00Z

@copilot resolve the merge conflicts in this pull request

Evangelink · 2026-06-22T09:55:41Z

@copilot resolve the merge conflicts in this pull request

…-blazoraot-tests # Conflicts: # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/ComputeReferenceStaticWebAssetItemsTest.cs

Three files merged in from main still used xUnit constructs after the project moved to MSTest.Sdk, breaking the build: - GenerateStaticWebAssetsPropsFileMultiThreadingTest - StaticWebAssetsGeneratePackManifestMultiThreadingTest - TypeScriptIntegrationTest Convert [Fact] to [TestMethod], add [TestClass]/[DoNotParallelize], implement the now-abstract RestoreNugetPackagePath, replace the ITestOutputHelper ctor with the parameterless MSTest pattern, and use TestContext.CancellationToken. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…-blazoraot-tests

This test file was added on main by dotnet#54704 after this branch migrated Microsoft.NET.Sdk.StaticWebAssets.Tests to MSTest.Sdk, so the merge reintroduced xUnit [Fact] usage that no longer compiles (CS0246 FactAttribute/Fact). Convert it to [TestClass]/[TestMethod] with [DoNotParallelize], matching the sibling MultiThreading tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Evangelink · 2026-06-22T17:25:33Z

/ba-g unrelated test issues

The migration tooling inserted large numbers of blank lines throughout the StaticWebAssets/Blazor test files. Restore the original blank-line layout from main while preserving all migrated content (xUnit->MSTest attribute swaps, usings, [TestClass]). No non-blank content changes; reduces the diff by ~50k spurious lines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…onErrorDetectorTests A merge with main reintroduced the xUnit [Fact] version of this file while the Microsoft.DotNet.Cli.Utils.Tests project is MSTest.Sdk, causing CS0246 ('Fact' could not be found) and breaking every build leg. Restore the [TestClass]/[TestMethod] version that exists on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The xUnit project disabled parallelization assembly-wide via [assembly: CollectionBehavior(DisableTestParallelization = true)]. The MSTest migration dropped that and inherited the repo-wide MethodLevel default, so methods now run in parallel. These integration tests are not parallel-safe: many methods in a class share a fixed test asset directory (helpers use [CallerMemberName]) and several task tests mutate the process-global current directory via Directory.SetCurrentDirectory, producing file-in-use, file-already-exists, missing-metadata and deleted-cwd (GetCwd) races. Setting MSTestParallelizeScope=None emits [assembly: DoNotParallelize], restoring the original fully-serialized semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Resolve conflicts in test files migrated to MSTest. Both main and this branch performed the equivalent xUnit->MSTest migration, so conflicts were limited to whitespace, attribute ordering, and per-test [DoNotParallelize] annotations. This branch fully serializes the StaticWebAssets test assembly via MSTestParallelizeScope=None, making main's granular [DoNotParallelize] attributes redundant, so the branch's versions were kept. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts: # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/CollectStaticWebAssetsToCopyMultiThreadingTest.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/MergeConfigurationPropertiesMultiThreadingTest.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/ReadStaticWebAssetsManifestFileMultiThreadingTest.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/StaticWebAssetTaskEnvironmentTests.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/StaticWebAssetsGeneratePackManifestMultiThreadingTest.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/StaticWebAssetsGeneratePackagePropsFileMultiThreadingTest.cs # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/UpdatePackageStaticWebAssetsMultiThreadingTest.cs

Evangelink · 2026-06-26T11:49:27Z

/ba-g timeout issue with Microsoft.WebTools.AspireService.Tests.dll

Migrates the three test projects that still used xUnit (v3) to MSTest.Sdk on Microsoft.Testing.Platform, following the pattern established by the sibling migration PRs (dotnet#54883, dotnet#54862, dotnet#54904): - test/Microsoft.NET.Build.Containers.IntegrationTests - test/TemplateEngine/.../TemplateVerifier.IntegrationTests - test/TemplateEngine/.../TemplateVerifier.UnitTests Verify.XunitV3 blocker (the two TemplateVerifier projects): The TemplateVerifier tool''s VerificationEngine drives snapshot verification through Verify.XunitV3 by default, which resolves the running test from xUnit''s ambient context and fails under MSTest (TestContext.TestMethod is null). Added a pluggable static VerificationEngine.DirectoryVerifier hook (with a NoInlining DefaultVerifyDirectory that keeps the xUnit reference off the default path) so MSTest consumers route directory verification to VerifyMSTest.Verifier.VerifyDirectory. Each migrated project wires this via a ModuleInitializer (VerifyDirectoryInitializer) and marks its snapshot classes [UsesVerify]; tests reference Verify.MSTest instead of Verify.XunitV3. test/TemplateEngine/Directory.Build.props now references Microsoft.NET.TestFramework.MSTest for UsingMSTestSdk projects (and keeps the xUnit framework for the rest), and sets SolutionDir/SolutionName so Verify''s solution auto-discovery does not warn under warnaserror. Containers.IntegrationTests: custom xUnit Docker Fact/Theory attributes became MSTest ConditionBaseAttribute gates (DockerUnavailableCondition, PodmanCliCondition, ContainerdStoreUnavailableCondition, DockerSupportsArchCondition); collection definitions became [DoNotParallelize]; ITestOutputHelper injection became SdkTest.Log; [Fact]/[Theory]/[InlineData] -> [TestMethod]/[DataRow]; assertions ported to MSTest. All three projects build cleanly (0 errors, 0 warnings). Tests were not run as part of this change, matching the sibling migration PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Migrate Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests to MSTest.Sdk o…

2e9e5ef

…n MTP Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 18, 2026 12:56

Evangelink requested a review from a team as a code owner June 18, 2026 12:56

Copilot started reviewing on behalf of Evangelink June 18, 2026 12:56 View session

Copilot AI reviewed Jun 18, 2026

Evangelink and others added 2 commits June 18, 2026 16:10

Merge remote-tracking branch 'fork/evangelink/mstest-testframework-fo…

283c29d

…undation' into evangelink/mstest-mtp-blazoraot-tests

Merge remote-tracking branch 'origin/main' into evangelink/mstest-mtp…

a5a86d8

…-blazoraot-tests # Conflicts: # test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/ComputeReferenceStaticWebAssetItemsTest.cs

Evangelink enabled auto-merge June 22, 2026 10:10

Copilot AI and others added 2 commits June 22, 2026 12:41

Merge branch 'main' into evangelink/mstest-mtp-blazoraot-tests

bf569ec

Evangelink and others added 2 commits June 22, 2026 14:58

Merge remote-tracking branch 'origin/main' into evangelink/mstest-mtp…

0318219

…-blazoraot-tests

This was referenced Jun 22, 2026

Template Engine SSL Connection Issue #51574

Open

Known Test Repository Issue Sometimes Misses Test Failures dotnet/dnceng#6411

Open

JeremyKuhne requested changes Jun 22, 2026

View reviewed changes

Comment thread test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/Globbing/PathTokenizerTest.cs Outdated

Evangelink and others added 6 commits June 22, 2026 19:50

Merge branch 'main' into evangelink/mstest-mtp-blazoraot-tests

f3a760c

Merge branch 'main' into evangelink/mstest-mtp-blazoraot-tests

347b5ec

build-analysis Bot mentioned this pull request Jun 25, 2026

TemplateEngineToolDiscovery Network Failure: Unable to read data from the transport connection: Connection reset by peer #51154

Closed

Evangelink mentioned this pull request Jun 25, 2026

Migrate remaining xUnit test projects to MSTest.Sdk on MTP #54976

Merged

Evangelink and others added 2 commits June 25, 2026 16:19

Remove duplicate using directives in TypeScriptIntegrationTest

d280d99

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

nohwnd approved these changes Jun 26, 2026

View reviewed changes

drognanar approved these changes Jun 26, 2026

View reviewed changes

YuliiaKovalova approved these changes Jun 26, 2026

View reviewed changes

JeremyKuhne approved these changes Jun 26, 2026

View reviewed changes

Evangelink merged commit 08bc948 into dotnet:main Jun 26, 2026
22 of 25 checks passed

dotnet-maestro Bot mentioned this pull request Jun 27, 2026

[main] Source code updates from dotnet/sdk dotnet/dotnet#7409

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jun 29, 2026

Evangelink deleted the evangelink/mstest-mtp-blazoraot-tests branch June 29, 2026 17:46

Navigation Menu

Uh oh!

Migrate Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests to MSTest.Sdk on MTP - #54862

Migrate Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests to MSTest.Sdk on MTP#54862
Evangelink merged 16 commits into
dotnet:mainfrom
Evangelink:evangelink/mstest-mtp-blazoraot-tests

Evangelink commented Jun 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Evangelink commented Jun 20, 2026

Uh oh!

Evangelink commented Jun 22, 2026

Uh oh!

Evangelink commented Jun 22, 2026

Uh oh!

Uh oh!

Evangelink commented Jun 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Evangelink commented Jun 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Evangelink commented Jun 20, 2026

Uh oh!

Evangelink commented Jun 22, 2026

Uh oh!

Evangelink commented Jun 22, 2026

Uh oh!

Uh oh!

Evangelink commented Jun 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants