zlib-ng patch for build failure caught in sdk but not in runtime#42122
Closed
carlossanlop wants to merge 1 commit into
Closed
zlib-ng patch for build failure caught in sdk but not in runtime#42122carlossanlop wants to merge 1 commit into
carlossanlop wants to merge 1 commit into
Conversation
carlossanlop
requested review from
akoeplinger,
directhex,
ericstj,
hoyosjs,
jkoritzinsky and
jkotas
ghost
added
Contributor
Author
|
The patch is not relative to the correct folder, and I was told to instead add it to the deps flow PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed these instructions: https://github.com/dotnet/source-build/blob/main/Documentation/patching-guidelines.md
CI failure in the SDK ingestion of runtime: https://dev.azure.com/dnceng-public/public/_build/results?buildId=734455&view=logs&j=684db19f-7f29-59a3-2a09-79422e6d4bae&t=d0c42288-a203-5a4c-a6e2-3bd237c51a8d
Fix currently being tested in a runtime PR: dotnet/runtime#104750
I do not know if we would normally want a patch like this merged into the repo or just open a PR to verify the fix worked. Please let me know. Meanwhile I will convert this to draft.