Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
97d4730
Implement more ServicePoint properties
Jan 26, 2024
b9fdca4
Implement more properties
Jan 31, 2024
69055bb
Make implementation correct
Feb 1, 2024
3591f1a
Change UseNagleAlgorithm default to false
Feb 1, 2024
d861319
Update src/libraries/System.Net.Requests/src/System/Net/HttpWebReques…
Feb 5, 2024
340d7e4
Merge branch 'main' into httpwebrequest-implement-more-property
Feb 5, 2024
043647c
Review feedback
Feb 9, 2024
f843727
Start implement DnsRoundRobin
Feb 9, 2024
f296718
Merge branch 'main' into httpwebrequest-implement-more-property
Feb 9, 2024
c61e5ed
remove passing parameter over ctor for static prop
Feb 9, 2024
30bd75c
Change DefaultMaximumErrorResponseLength default value to -1
Feb 9, 2024
cf3003d
Update ServicePoint parameter passing, implement Certificate on Servi…
Feb 11, 2024
33abd52
Change servicePoint to nullable parameter again and fix bind test
Feb 12, 2024
3033c4a
Change static variable test to RemoteExecutor
Feb 12, 2024
2ee83de
Fix bind throw test for linux and add async to remote executor
Feb 12, 2024
3be4532
Update src/libraries/System.Net.Requests/src/System/Net/HttpWebReques…
Feb 15, 2024
f1ea117
Review feedback
Feb 15, 2024
9260105
Merge branch 'httpwebrequest-implement-more-property' of github.com:l…
Feb 15, 2024
8d28f97
Skip throw bind on Linux
Feb 16, 2024
970bbb1
Add disable reuseaddr
Feb 18, 2024
d9ef66d
Revert "Add disable reuseaddr"
Feb 18, 2024
67655be
some changes on tests
Feb 18, 2024
86f156c
Refactor GetResponseStream method to use TruncatedReadStream
Feb 20, 2024
ca6b379
Fix tests
Feb 20, 2024
89040f6
Convert static property test to RemoteExecutor
Feb 20, 2024
66f7abd
Delete unused NameResolution project from Requests csproj
Feb 20, 2024
50a0f2f
Revert "Delete unused NameResolution project from Requests csproj"
Feb 20, 2024
f9cb55f
Fix socket shutdown
Feb 20, 2024
8c3f0c4
simple changes on test
Feb 20, 2024
a5c136a
Change sync call inside RemoteExecutor
Feb 22, 2024
1d9708d
Update src/libraries/System.Net.Requests/src/System/Net/HttpWebRespon…
Feb 27, 2024
ab78cd1
Merge branch 'main' into httpwebrequest-implement-more-property
Feb 27, 2024
06f8d95
Apply suggestions from code review
Feb 28, 2024
05af2e0
Review feedback
Feb 28, 2024
47d7f27
Change exception handling on remote executor test
Feb 28, 2024
7aa734f
Change connection logic
Feb 28, 2024
657a334
Revert "Change exception handling on remote executor test"
Feb 28, 2024
06f1324
Add forgotten disposal
Feb 28, 2024
520ba04
Revert "Change connection logic"
Feb 28, 2024
a9368bf
Review feedback
Feb 28, 2024
f8cdea3
Apply suggestions from code review
Mar 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -806,10 +806,12 @@ public Version ProtocolVersion
if (value.Equals(HttpVersion.Version11))
{
IsVersionHttp10 = false;
ServicePoint.ProtocolVersion = HttpVersion.Version11;
Comment thread
MihaZupan marked this conversation as resolved.
}
else if (value.Equals(HttpVersion.Version10))
{
IsVersionHttp10 = true;
ServicePoint.ProtocolVersion = HttpVersion.Version10;
}
else
{
Expand Down Expand Up @@ -1621,6 +1623,13 @@ private static HttpClient CreateHttpClient(HttpClientParameters parameters, Http
handler.UseCookies = false;
}

if (parameters.ServicePoint is { } servicePoint)
{
handler.MaxConnectionsPerServer = servicePoint.ConnectionLimit;
handler.PooledConnectionIdleTimeout = servicePoint.MaxIdleTime == -1 ? Threading.Timeout.InfiniteTimeSpan : TimeSpan.FromMilliseconds(servicePoint.MaxIdleTime);
Comment thread
MihaZupan marked this conversation as resolved.
Outdated
handler.PooledConnectionLifetime = servicePoint.ConnectionLeaseTimeout == -1 ? Threading.Timeout.InfiniteTimeSpan : TimeSpan.FromMilliseconds(servicePoint.ConnectionLeaseTimeout);
Comment thread
liveans marked this conversation as resolved.
Outdated
Comment thread
liveans marked this conversation as resolved.
Outdated
}

Debug.Assert(handler.UseProxy); // Default of handler.UseProxy is true.
Debug.Assert(handler.Proxy == null); // Default of handler.Proxy is null.

Expand Down