Skip to content

Swap out a Debug.Fail for a more graceful diagnostic failure. #65861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 2 commits into from
Feb 24, 2022
Merged

Swap out a Debug.Fail for a more graceful diagnostic failure. #65861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174a560
Swap out a Debug.Fail for a more graceful diagnostic failure.
jkoritzinsky Feb 24, 2022
7ed2312
Add back the logging from the failure case, but not in a way that cau…
jkoritzinsky Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,11 @@ private static TargetFramework DetermineTargetFramework(Compilation compilation,
switch (namedArg.Key)
{
default:
Debug.Fail($"An unknown member '{namedArg.Key}' was found on {attrData.AttributeClass}");
Comment thread
jkoritzinsky marked this conversation as resolved.
continue;
// This should never occur in a released build,
// but can happen when evolving the ecosystem.
// Return null here to indicate invalid attribute data.
Debug.WriteLine($"An unknown member '{namedArg.Key}' was found on {attrData.AttributeClass}");
return null;
case nameof(GeneratedDllImportData.StringMarshalling):
userDefinedValues |= DllImportMember.StringMarshalling;
// TypedConstant's Value property only contains primitive values.
Expand Down