don't run CanZipNamedPipe test on iOS/tvOS#62477
Merged
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue Detailsfixes #62341
|
stephentoub
reviewed
Dec 7, 2021
| Task.Run(() => | ||
| { | ||
| using FileStream fs = new (fifoPath, FileMode.Open, FileAccess.Write, FileShare.Read); | ||
| using FileStream fs = new (fifoPath, FileMode.Open, FileAccess.Write, FileShare.Read, bufferSize: 0); |
Member
There was a problem hiding this comment.
This is unrelated to iOS and instead for my comments on the previous PR? Just confirming.
Member
Author
There was a problem hiding this comment.
This is unrelated to iOS and instead for my comments on the previous PR? Just confirming.
Yes, exactly. I did not want to send a new PR for this small change so I've used the test failure as an opportunity to address the old feedback as well.
stephentoub
approved these changes
Dec 7, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62341