Skip to content

File.CopyTo: try to pre-allocate disk space for large destination files #61676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 3 commits into from
Closed

File.CopyTo: try to pre-allocate disk space for large destination files #61676

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a27e9f
File.Copy: try to pre-allocate disk space for large destination files
adamsitnik Nov 16, 2021
1a1f53e
Update src/libraries/Native/Unix/System.Native/pal_io.c
adamsitnik Nov 17, 2021
2d6f1a0
Merge remote-tracking branch 'upstream/main' into fileCopyUsePrealloc…
adamsitnik Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/libraries/Native/Unix/System.Native/pal_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,6 +1173,15 @@ int32_t SystemNative_CopyFile(intptr_t sourceFd, intptr_t destinationFd, int64_t
copied = ret == 0;
}
#endif

#if HAVE_FALLOCATE // Linux
if (sourceLength > 81920) // BufferSize used by CopyFile_ReadWrite (would require more than 1 sys-call)
Comment thread
adamsitnik marked this conversation as resolved.
Outdated
{
// try to pre-allocate disk space for large destination files
while ((ret = fallocate(outFd, FALLOC_FL_KEEP_SIZE, (off_t)0, (off_t)sourceLength)) == -1 && errno == EINTR);
}
#endif

#if HAVE_SENDFILE_4
// Try copying the data using sendfile.
if (!copied && sourceLength != 0)
Expand Down