Skip to content

Fix GetLoadContextForDynamicAssembly GC Stress Fail#53341

Merged
vitek-karas merged 1 commit into
dotnet:mainfrom
Ap0k:bugfix/GetLoadContextForDynamicAssembly_GCStressFail
May 28, 2021
Merged

Fix GetLoadContextForDynamicAssembly GC Stress Fail#53341
vitek-karas merged 1 commit into
dotnet:mainfrom
Ap0k:bugfix/GetLoadContextForDynamicAssembly_GCStressFail

Conversation

@Ap0k

@Ap0k Ap0k commented May 27, 2021

Copy link
Copy Markdown
Contributor

I think this will fix the #53335

@ghost ghost added the area-AssemblyLoader-coreclr only use for closed issues label May 27, 2021
@ghost

ghost commented May 27, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

I think this will fix the #53335

Author: Ap0k
Assignees: -
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@vitek-karas

Copy link
Copy Markdown
Member

The test looks remarkably similar to the one in #49387. Should we delete one of them?

@Ap0k

Ap0k commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

The test looks remarkably similar to the one in #49387. Should we delete one of them?

I think we should leave both tests, but in this test remove the assembly search in ALC.Assemblies

@Ap0k Ap0k force-pushed the bugfix/GetLoadContextForDynamicAssembly_GCStressFail branch from df1f669 to 183e906 Compare May 27, 2021 08:53
@vitek-karas vitek-karas merged commit 4387828 into dotnet:main May 28, 2021
@vitek-karas

Copy link
Copy Markdown
Member

Thanks @Ap0k for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-AssemblyLoader-coreclr only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants