Fix thread-statics bootstrap recursion on WASM#131120
Draft
davidwrighton with Copilot wants to merge 1 commit into
Draft
Fix thread-statics bootstrap recursion on WASM#131120davidwrighton with Copilot wants to merge 1 commit into
davidwrighton with Copilot wants to merge 1 commit into
Conversation
…tstrap recursion Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
davidwrighton
July 21, 2026 00:12
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On WASM,
GetThreadStaticsBase()computes theThreadLocalData*by taking the address ofDirectOnThreadLocalData.pNativeThread. On WASM, that field access goes throughStaticsHelpers.GetNonGCThreadStaticBase, which itself callsGetThreadStaticsBase()— infinite recursion.Fix: add a
GetThreadStaticsBaseNativeFCall (WASM-only) that returns&t_ThreadStaticsdirectly from native, bypassing the managed thread-static lookup path.Thread.CoreCLR.cs:#if TARGET_WASMpath inGetThreadStaticsBase()callsGetThreadStaticsBaseNative()instead of the&pNativeThreadpointer arithmetic; declares the FCall as[MethodImpl(InternalCall)].comsynchronizable.h: declaresGetThreadStaticsBaseNativeFCDECL (WASM-only).comsynchronizable.cpp: implements it returning(void*)&t_ThreadStatics; adds#include "threadstatics.h".ecalllist.h: registers the FCall (WASM-only).Extracted from main...AndyAyersMS:runtime:next-blocker-spc.