Consolidate crossgen2-composite and r2r into crossgen2-outerloop pipeline#130370
Consolidate crossgen2-composite and r2r into crossgen2-outerloop pipeline#130370jtschuster wants to merge 2 commits into
Conversation
Fold the composite-mode coverage that was unique to the crossgen2-composite pipeline into the crossgen2-outerloop pipeline, and stop running crossgen2-composite on a daily schedule. - Add linux_arm and windows_x86 to the R2R_Composite job in outerloop. - Add an R2R_Composite_LargeVersionBubble job (linux_x64, windows_x64) to outerloop. - Remove the daily cron schedule from crossgen2-composite; it can still be invoked manually to validate a change. The outerloop pipeline already builds the same Checked runtime and runs composite mode on the shared platforms at Pri1, so the daily crossgen2-composite run was largely duplicated work. Moving the remaining unique configurations into outerloop keeps coverage (now at Pri1) while eliminating the redundant daily run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run runtime-coreclr crossgen2-outerloop |
|
No pipelines are associated with this pull request. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Consolidates composite-mode crossgen2 coverage into the existing crossgen2-outerloop pipeline and disables the daily scheduled run of the dedicated crossgen2-composite pipeline, keeping composite coverage while reducing duplicated CI work.
Changes:
- Expanded the
R2R_Compositeouterloop job matrix to includelinux_armandwindows_x86. - Added a new
R2R_Composite_LargeVersionBubbleouterloop job (linux_x64, windows_x64) to preserve “large version bubble” composite coverage. - Removed the cron schedule from
crossgen2-composite.ymlso it runs only when manually invoked.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/coreclr/crossgen2-outerloop.yml | Adds missing composite-mode matrices (linux_arm/windows_x86) and introduces a Pri1 large-version-bubble composite job. |
| eng/pipelines/coreclr/crossgen2-composite.yml | Removes the daily YAML schedule so this pipeline is no longer automatically run. |
The standalone crossgen2 r2r pipeline (eng/pipelines/coreclr/r2r.yml) runs the non-composite ReadyToRun coreclr test suite at Pri1 (testGroup: outerloop). The crossgen2-outerloop pipeline already runs an identical non-composite R2R job on the same daily schedule, on a strict superset of platforms (it additionally covers osx_x64). Verified empirically that the Helix work-item sets are identical on the shared platforms (e.g. linux_x64 and windows_x64 each produced the exact same 90/91 work items on the same queues), so r2r.yml provides no unique coverage. Note: the ADO pipeline definition (runtime-coreclr r2r) points at this YAML path and must be removed/disabled by infra as a follow-up, or it will fail once the file is gone. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
MichalStrehovsky
left a comment
There was a problem hiding this comment.
If you can get a review from someone who knows what these are, it would be better for them to sign off, but otherwise signed off.
Summary
Consolidates duplicated daily crossgen2 / ReadyToRun coverage into the crossgen2-outerloop pipeline:
linux_armandwindows_x86on theR2R_Compositejob, plus a newR2R_Composite_LargeVersionBubblejob (linux_x64,windows_x64). These were the only configurations unique to crossgen2-composite.runtime-coreclr r2rpipeline (eng/pipelines/coreclr/r2r.yml) - it's fully redundant with outerloop's non-compositeR2Rjob.Deleting
r2r.ymlremoves the YAML but not the ADO pipeline definition. The enabledruntime-coreclr r2rdefinition points at this path and will fail once merged unless we disables or removes it. The now-unscheduledcrossgen2-compositedefinition can optionally be retired too.