Skip to content

Fix Idn failing tests#115018

Merged
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:IdnTests
Apr 25, 2025
Merged

Fix Idn failing tests#115018
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:IdnTests

Conversation

@tarekgh

@tarekgh tarekgh commented Apr 24, 2025

Copy link
Copy Markdown
Member

Fixes #115006

Copilot AI review requested due to automatic review settings April 24, 2025 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses failing tests by updating the ICU version threshold for selecting the appropriate IdnaTest file.

  • Lower the version threshold for selecting "IdnaTest_15_1.txt" to 72.
  • Adjust the test configuration in the Factory.cs file to match expected ICU behavior.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are also failing in the prev4 branch. Can you please backport? It would be tell-mode, I can merge it.

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it fixes the issue. Seems like we're updating based on observation of which ICU versions we see in the places we test - anything we need to do to look at the ICU build / repo to find exact version where this change was introduced?

@carlossanlop

Copy link
Copy Markdown
Contributor

@ericstj

ericstj commented Apr 24, 2025

Copy link
Copy Markdown
Member

Confirmed it's also affecting prev4: https://github.com/dotnet/runtime/pull/114979/checks?check_run_id=41117511379

Yes, I opened the issue based on a P4 PR

@tarekgh

tarekgh commented Apr 24, 2025

Copy link
Copy Markdown
Member Author

/backport to release/10.0-preview4

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0-preview4: https://github.com/dotnet/runtime/actions/runs/14652881804

@tarekgh

tarekgh commented Apr 24, 2025

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14653792031

@github-actions

Copy link
Copy Markdown
Contributor

@tarekgh backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix Idn failing tests
Using index info to reconstruct a base tree...
M	src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
CONFLICT (content): Merge conflict in src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix Idn failing tests
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Globalization.Tests.IdnMappingIdnaConformanceTests failing on Windows

4 participants