Fix wrong Region Info Names#108466
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
| public void BuiltInRegionListTest() | ||
| { | ||
| // Ensure we can create all region info objects from the built-in list | ||
| Dictionary<string, string> regionNames = (Dictionary<string, string>)typeof(RegionInfo).Assembly.GetType("System.Globalization.CultureData").GetProperty("RegionNames", BindingFlags.Static | BindingFlags.NonPublic).GetValue(null); |
There was a problem hiding this comment.
Is there another source we could be enumerating? e.g. how does this related to the cultures enumerable from CultureInfo.GetCultures(All)... if we were to parse the regions out of those, would that be equivalent to (some of) this data?
There was a problem hiding this comment.
Culture enumeration can be done too but, in our data, we add some extra data that is not getting from the enumeration. That is why I decided to se the data we build.
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11166289238 |
* Fix wrong RegionInfo Names * Exclude the test on Windows 8 for the lack of full globalization data
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11183150514 |
* Fix wrong RegionInfo Names * Exclude the test on Windows 8 for the lack of full globalization data
3 participants
We had some typo in some of the region info data. The change here is fixing that.