System.Diagnostics.CorrelationManager is not thread-safe

[mahalex]

Description

The following code crashes due to issue in System.Diagnostics.CorrelationManager, which appears to be not thread-safe (even though it uses an AsyncLocalStackWrapper).

using System.Diagnostics;
using System.Threading;

namespace CorrelationManagerExample
{
    class Program
    {
        static void Main(string[] args)
        {
            var t1 = new Thread(Method);
            var t2 = new Thread(Method);
            t1.Start();
            t2.Start();
        }

        private static void Method()
        {
            Trace.CorrelationManager.StartLogicalOperation();
            Trace.CorrelationManager.StopLogicalOperation();
        }
    }
}

Configuration

I verified by compiling and running this code using .NET SDK 5.0.201 on Windows 10 (x64).

Regression?

A similar issue was reported in 2005 against the .NET Framework implementation, and was apparently fixed then.
So recent versions of .NET Framework do not have this issue (I verified this by re-targeting the project to net461).

Other information

Stack trace:

Unhandled exception. System.InvalidOperationException: Stack empty.
   at System.Collections.Stack.Pop()
   at System.Diagnostics.CorrelationManager.AsyncLocalStackWrapper.Pop()
   at System.Diagnostics.CorrelationManager.StopLogicalOperation()
   at CorrelationManagerExample.Program.Method() in C:\git\CorrelationManagerExample\CorrelationManagerExample\Program.cs:line 19
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ChristophLindemann]

The code seems to be a verbatime copy (apart from reordering members) of an idea from @stephentoub that he posted as a comment to the original code review, even though he noted: "Take this with a grain of salt... I've not tested it so there may be an issue here and there."

This copy/paste is also the reason for #38176

Tagging subscribers to this area: @tommcdon, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

The following code crashes due to issue in System.Diagnostics.CorrelationManager, which appears to be not thread-safe (even though it uses an AsyncLocalStackWrapper).

using System.Diagnostics;
using System.Threading;

namespace CorrelationManagerExample
{
    class Program
    {
        static void Main(string[] args)
        {
            var t1 = new Thread(Method);
            var t2 = new Thread(Method);
            t1.Start();
            t2.Start();
        }

        private static void Method()
        {
            Trace.CorrelationManager.StartLogicalOperation();
            Trace.CorrelationManager.StopLogicalOperation();
        }
    }
}

Configuration

I verified by compiling and running this code using .NET SDK 5.0.201 on Windows 10 (x64).

Regression?

A similar issue was reported in 2005 against the .NET Framework implementation, and was apparently fixed then.
So recent versions of .NET Framework do not have this issue (I verified this by re-targeting the project to net461).

Other information

Stack trace:

Unhandled exception. System.InvalidOperationException: Stack empty.
   at System.Collections.Stack.Pop()
   at System.Diagnostics.CorrelationManager.AsyncLocalStackWrapper.Pop()
   at System.Diagnostics.CorrelationManager.StopLogicalOperation()
   at CorrelationManagerExample.Program.Method() in C:\git\CorrelationManagerExample\CorrelationManagerExample\Program.cs:line 19
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Author:	mahalex
Assignees:	-
Labels:	area-System.Diagnostics, untriaged
Milestone:	-

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

The following code crashes due to issue in System.Diagnostics.CorrelationManager, which appears to be not thread-safe (even though it uses an AsyncLocalStackWrapper).

using System.Diagnostics;
using System.Threading;

namespace CorrelationManagerExample
{
    class Program
    {
        static void Main(string[] args)
        {
            var t1 = new Thread(Method);
            var t2 = new Thread(Method);
            t1.Start();
            t2.Start();
        }

        private static void Method()
        {
            Trace.CorrelationManager.StartLogicalOperation();
            Trace.CorrelationManager.StopLogicalOperation();
        }
    }
}

Configuration

I verified by compiling and running this code using .NET SDK 5.0.201 on Windows 10 (x64).

Regression?

A similar issue was reported in 2005 against the .NET Framework implementation, and was apparently fixed then.
So recent versions of .NET Framework do not have this issue (I verified this by re-targeting the project to net461).

Other information

Stack trace:

Unhandled exception. System.InvalidOperationException: Stack empty.
   at System.Collections.Stack.Pop()
   at System.Diagnostics.CorrelationManager.AsyncLocalStackWrapper.Pop()
   at System.Diagnostics.CorrelationManager.StopLogicalOperation()
   at CorrelationManagerExample.Program.Method() in C:\git\CorrelationManagerExample\CorrelationManagerExample\Program.cs:line 19
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Author:	mahalex
Assignees:	noahfalk
Labels:	area-System.Diagnostics, area-System.Diagnostics.Tracing
Milestone:	6.0.0