[Testing] Fixed test failure in net11 branch - 2 - #35345
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35345Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35345" |
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates a MAUI Appium UI test to avoid failing when the HostApp shows its “no internet access” page instead of loading the test content.
Changes:
- Added a
VerifyInternetConnectivity()call at the start ofWebViewEvaluateJavaScriptReturnsCorrectResults()to mark the test inconclusive when the device has no internet.
| { | ||
| // Test String Result | ||
| VerifyInternetConnectivity(); | ||
| App.WaitForElement("TestStringButton"); | ||
| App.Tap("TestStringButton"); |
|
|
1 similar comment
|
|
This pull request introduces a small but important change to the
WebViewEvaluateJavaScriptReturnsCorrectResultstest method by adding a call toVerifyInternetConnectivity()at the beginning of the test. This ensures that the test only proceeds if there is an active internet connection, which can help prevent false negatives due to connectivity issues.VerifyInternetConnectivity()at the start of theWebViewEvaluateJavaScriptReturnsCorrectResultstest inIssue20288.csto ensure the test only runs when internet access is available.