Skip to content

[Testing] Fixed test failure in net11 branch - 2 - #35345

Merged
jfversluis merged 1 commit into
dotnet:net11.0from
TamilarasanSF4853:fix-net11-test-failures-2
May 11, 2026
Merged

[Testing] Fixed test failure in net11 branch - 2#35345
jfversluis merged 1 commit into
dotnet:net11.0from
TamilarasanSF4853:fix-net11-test-failures-2

Conversation

@TamilarasanSF4853

Copy link
Copy Markdown
Contributor

This pull request introduces a small but important change to the WebViewEvaluateJavaScriptReturnsCorrectResults test method by adding a call to VerifyInternetConnectivity() at the beginning of the test. This ensures that the test only proceeds if there is an active internet connection, which can help prevent false negatives due to connectivity issues.

  • Added a call to VerifyInternetConnectivity() at the start of the WebViewEvaluateJavaScriptReturnsCorrectResults test in Issue20288.cs to ensure the test only runs when internet access is available.
  • Re-saved the correct iOS 18 images for BoxViewFeatureTests due to wrong images being re-saved in this PR: [NET11.0] Provided Fill property support for BoxView control #31789.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35345

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35345"

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label May 7, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label May 7, 2026
@sheiksyedm sheiksyedm added the area-testing Unit tests, device tests label May 7, 2026
@sheiksyedm
sheiksyedm marked this pull request as ready for review May 7, 2026 13:17
Copilot AI review requested due to automatic review settings May 7, 2026 13:17
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a MAUI Appium UI test to avoid failing when the HostApp shows its “no internet access” page instead of loading the test content.

Changes:

  • Added a VerifyInternetConnectivity() call at the start of WebViewEvaluateJavaScriptReturnsCorrectResults() to mark the test inconclusive when the device has no internet.

Comment on lines 19 to 23
{
// Test String Result
VerifyInternetConnectivity();
App.WaitForElement("TestStringButton");
App.Tap("TestStringButton");
@MauiBot

MauiBot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

1 similar comment
@MauiBot

MauiBot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

@jfversluis
jfversluis merged commit ce6edd6 into dotnet:net11.0 May 11, 2026
200 of 209 checks passed
@github-actions github-actions Bot added this to the .NET 11.0-preview4 milestone May 11, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants