[Testing] Fixed test failure in net11 branch - #35225
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35225Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35225" |
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR adjusts MAUI UI tests in TestCases.Shared.Tests to reduce flakiness: it switches Material3 slider tests to wait on a stable label after returning from the options page, excludes several map drag-based tests on MacCatalyst because of the known DragCoordinates regression, and tweaks one issue screenshot crop.
Changes:
- Replaced
WaitForElementTillPageNavigationSettled(...)targets inMaterial3SliderFeatureTestswithMinimumValueLabel. - Wrapped several drag-dependent
MapFeatureTestsin#if TEST_FAILS_ON_CATALYSTso they are skipped on MacCatalyst. - Adjusted the non-Android screenshot crop in
Issue33407.
Reviewed changes
Copilot reviewed 3 out of 25 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33407.cs |
Changes screenshot cropping for the rotation/keyboard regression test. |
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/Material3SliderFeatureTests.cs |
Updates post-Apply wait targets for Material3 slider screenshot tests. |
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/MapFeatureTests.cs |
Excludes several MacCatalyst map drag tests behind platform-failure guards. |
| #if TEST_FAILS_ON_CATALYST // Issue - https://github.com/dotnet/maui/issues/35222 | ||
| [Test] |
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request updates UI test cases for the Material3 Slider and Map features to improve test reliability and address platform-specific issues. The main changes involve standardizing the element used to determine when the page navigation has settled in Material3 Slider tests and conditionally disabling certain Map tests on the Catalyst platform due to a known issue.
Material3 Slider Test Improvements:
App.WaitForElementTillPageNavigationSettled("SliderControl")and similar calls to instead wait for the"MinimumValueLabel"element, ensuring more reliable test synchronization after UI changes.Map Feature Test Adjustments:
#if TEST_FAILS_ON_CATALYSTpreprocessor directives to conditionally exclude them on Catalyst, referencing a known issue (https://github.com/dotnet/maui/issues/35222). This helps prevent false negatives in CI for that platform.Images:
These changes collectively improve the reliability and maintainability of the UI test suite across platforms.
Issue Found:
#35222