Skip to content

[Testing] Fixed test failure in net11 branch - #35225

Merged
PureWeen merged 3 commits into
dotnet:net11.0from
TamilarasanSF4853:fix-net11-test-failures
May 6, 2026
Merged

[Testing] Fixed test failure in net11 branch#35225
PureWeen merged 3 commits into
dotnet:net11.0from
TamilarasanSF4853:fix-net11-test-failures

Conversation

@TamilarasanSF4853

Copy link
Copy Markdown
Contributor

This pull request updates UI test cases for the Material3 Slider and Map features to improve test reliability and address platform-specific issues. The main changes involve standardizing the element used to determine when the page navigation has settled in Material3 Slider tests and conditionally disabling certain Map tests on the Catalyst platform due to a known issue.

Material3 Slider Test Improvements:

  • Updated all occurrences of App.WaitForElementTillPageNavigationSettled("SliderControl") and similar calls to instead wait for the "MinimumValueLabel" element, ensuring more reliable test synchronization after UI changes.

Map Feature Test Adjustments:

  • Wrapped several Map feature tests in #if TEST_FAILS_ON_CATALYST preprocessor directives to conditionally exclude them on Catalyst, referencing a known issue (https://github.com/dotnet/maui/issues/35222). This helps prevent false negatives in CI for that platform.

Images:

  • Added the base images and re-saved the valid images.

These changes collectively improve the reliability and maintainability of the UI test suite across platforms.

Issue Found:
#35222

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35225

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35225"

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Apr 29, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 29, 2026
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@sheiksyedm
sheiksyedm marked this pull request as ready for review May 5, 2026 07:18
Copilot AI review requested due to automatic review settings May 5, 2026 07:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts MAUI UI tests in TestCases.Shared.Tests to reduce flakiness: it switches Material3 slider tests to wait on a stable label after returning from the options page, excludes several map drag-based tests on MacCatalyst because of the known DragCoordinates regression, and tweaks one issue screenshot crop.

Changes:

  • Replaced WaitForElementTillPageNavigationSettled(...) targets in Material3SliderFeatureTests with MinimumValueLabel.
  • Wrapped several drag-dependent MapFeatureTests in #if TEST_FAILS_ON_CATALYST so they are skipped on MacCatalyst.
  • Adjusted the non-Android screenshot crop in Issue33407.

Reviewed changes

Copilot reviewed 3 out of 25 changed files in this pull request and generated 1 comment.

File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33407.cs Changes screenshot cropping for the rotation/keyboard regression test.
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/Material3SliderFeatureTests.cs Updates post-Apply wait targets for Material3 slider screenshot tests.
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/MapFeatureTests.cs Excludes several MacCatalyst map drag tests behind platform-failure guards.

Comment on lines +206 to 207
#if TEST_FAILS_ON_CATALYST // Issue - https://github.com/dotnet/maui/issues/35222
[Test]
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kubaflo
kubaflo enabled auto-merge (squash) May 6, 2026 14:35
@PureWeen
PureWeen disabled auto-merge May 6, 2026 20:42
@PureWeen
PureWeen merged commit 65d3f92 into dotnet:net11.0 May 6, 2026
204 of 210 checks passed
@github-actions github-actions Bot added this to the .NET 11.0-preview4 milestone May 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants